Re: [PATCH v4 1/9] rust: pci: add internal SR-IOV enable and disable helpers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: pci: missing #[inline] on abstraction functions forwarding to C bindings
--

commit c316165d2a3f7f2b9498fa8f5fcc7616b0e3fb32
Author: Peter Colberg <peter@colberg.org>

rust: pci: add internal SR-IOV enable and disable helpers

This commit wraps pci_enable_sriov() and pci_disable_sriov() on
Device<CoreInternal> for use by SR-IOV callback tokens. These operations
are kept internal to ensure drivers can only modify VFs through the
callback-scoped API.

> diff --git a/rust/kernel/pci/iov.rs b/rust/kernel/pci/iov.rs
> new file mode 100644
> index 0000000000000..1af5bdc198302
> --- /dev/null
> +++ b/rust/kernel/pci/iov.rs
[ ... ]
> +impl Device<device::CoreInternal<'_>> {
> +    /// Enable the Single Root I/O Virtualization (SR-IOV) capability for this device,
> +    /// where `nr_virtfn` is number of Virtual Functions (VF) to enable.
> +    #[expect(dead_code)]
> +    pub(crate) fn enable_sriov(&self, nr_virtfn: u16) -> Result {

[Severity: Low]
This isn't a bug, but does this abstraction method miss an inline annotation?
The Rust subsystem guidelines specify that functions forwarding to a C binding
call in the kernel crate should be annotated with inline to allow for
compiler optimization.

> +        // SAFETY:
[ ... ]
> +        // - The [`CoreInternal`] device context inherits from the [`Bound`] device context,
> +        //   which guarantees that the PF device is bound to a driver.
> +        to_result(unsafe { bindings::pci_enable_sriov(self.as_raw(), nr_virtfn.into()) })
> +    }
> +
> +    /// Disable the Single Root I/O Virtualization (SR-IOV) capability for this device.
> +    #[expect(dead_code)]
> +    pub(crate) fn disable_sriov(&self) {

[Severity: Low]
Similarly, should this method also include an inline annotation since it
directly forwards to the pci_disable_sriov C binding?

> +        // SAFETY:
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004120732.1045629-1-zhiw@nvidia.com?part=1