Re: [PATCH v4 3/9] rust: pci: add is_virtfn(), to check for VFs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: pci: is_virtfn() causes build failure without CONFIG_PCI_IOV
--

commit 391d320fa5a3d19a9fe3ffdc043f22844cce0dde
Author: John Hubbard <jhubbard@nvidia.com>

rust: pci: add is_virtfn(), to check for VFs

Add a method to check if a PCI device is a Virtual Function (VF) created
through Single Root I/O Virtualization (SR-IOV).

> diff --git a/rust/kernel/pci/iov.rs b/rust/kernel/pci/iov.rs
> index 1af5bdc198302..616ac40b8bcd4 100644
> --- a/rust/kernel/pci/iov.rs
> +++ b/rust/kernel/pci/iov.rs
> @@ -11,6 +11,15 @@
>      prelude::*, //
>  };
>  
> +impl Device {
> +    /// Returns `true` if this device is a Virtual Function (VF).
> +    #[inline]
> +    pub fn is_virtfn(&self) -> bool {

[Severity: Low]
Will this cause build failures for Rust drivers when CONFIG_PCI_IOV is
disabled?

Since this method is defined inside rust/kernel/pci/iov.rs, and that module
is guarded by #[cfg(CONFIG_PCI_IOV)] in rust/kernel/pci.rs, is_virtfn()
becomes conditionally compiled.

In the C API, the is_virtfn field on struct pci_dev is unconditionally
available, and drivers routinely check it unconditionally to skip PF-specific
setup. If a Rust driver does the same, it would fail to compile when
CONFIG_PCI_IOV=n. Could this be moved to an unconditionally compiled module?

> +        // SAFETY: `self.as_raw` is a valid pointer to a `struct pci_dev`.
> +        unsafe { (*self.as_raw()).is_virtfn() != 0 }
> +    }
> +}
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004120732.1045629-1-zhiw@nvidia.com?part=3