Re: [PATCH v4 4/9] rust: pci: add num_vf(), to return number of VFs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] rust: pci: missing #[inline] annotation on num_vf() abstraction
--

commit 631ac1e7bf636d5226a53e025ed45307e5f2d334
Author: Peter Colberg <peter@colberg.org>

rust: pci: add num_vf(), to return number of VFs

Add a method to return the number of Virtual Functions (VF) enabled for
a Physical Function (PF).

> diff --git a/rust/kernel/pci/iov.rs b/rust/kernel/pci/iov.rs
> index 616ac40b8bcd4..4ed6ba658e818 100644
> --- a/rust/kernel/pci/iov.rs
> +++ b/rust/kernel/pci/iov.rs
> @@ -20,6 +20,16 @@ pub fn is_virtfn(&self) -> bool {
>      }
>  }
>  
> +impl Device<device::Core<'_>> {
> +    /// Returns the number of Virtual Functions (VF) enabled for a Physical Function (PF).
> +    pub fn num_vf(&self) -> u16 {

[Severity: Low]
This isn't a bug, but this abstraction function forwards to a C binding
(bindings::pci_num_vf) and appears to be missing the #[inline] annotation.

According to the Rust subsystem guidelines, small functions or functions
forwarding to a C binding call in abstractions should be annotated with
#[inline].

Should an #[inline] attribute be added here?

> +        // SAFETY: `self.as_raw()` is valid and this call runs in the PCI core callback context.
> +        unsafe { bindings::pci_num_vf(self.as_raw()) }
> +            .try_into()
> +            .expect("pdev->sriov->num_VFs is u16")
> +    }
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261004120732.1045629-1-zhiw@nvidia.com?part=4