[PATCH V2 5/5] PCI: Enable 10-Bit tag support for PCIe RP devices

[PATCH V2 5/5] PCI: Enable 10-Bit tag support for PCIe RP devices

[Dongdong Liu]

PCIe spec 5.0r1.0 section 2.2.6.2 implementation note, In configurations
where a Requester with 10-Bit Tag Requester capability needs to target
multiple Completers, one needs to ensure that the Requester sends 10-Bit
Tag Requests only to Completers that have 10-Bit Tag Completer capability.
So we enable 10-Bit Tag Requester for root port only when the devices
under the root port support 10-Bit Tag Completer.

Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
---
 drivers/pci/pcie/portdrv_pci.c | 76 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 76 insertions(+)

diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
index c7ff1ee..19e6e62 100644
--- a/drivers/pci/pcie/portdrv_pci.c
+++ b/drivers/pci/pcie/portdrv_pci.c
@@ -90,6 +90,79 @@ static const struct dev_pm_ops pcie_portdrv_pm_ops = {
 #define PCIE_PORTDRV_PM_OPS	NULL
 #endif /* !PM */
 
+static int pci_10bit_tag_comp_support(struct pci_dev *dev, void *data)
+{
+	u8 *support = data;
+
+	if (*support == 0)
+		return 0;
+
+	if (!pci_is_pcie(dev)) {
+		*support = 0;
+		return 0;
+	}
+
+	/*
+	 * PCIe spec 5.0r1.0 section 2.2.6.2 implementation note
+	 * For configurations where a Requester with 10-Bit Tag Requester capability
+	 * targets Completers where some do and some do not have 10-Bit Tag
+	 * Completer capability, how the Requester determines which NPRs include
+	 * 10-Bit Tags is outside the scope of this specification.  So we do not consider
+	 * hotplug scenario.
+	 */
+	if (dev->is_hotplug_bridge) {
+		*support = 0;
+		return 0;
+	}
+
+
+	if (!(dev->devcap2 & PCI_EXP_DEVCAP2_10BIT_TAG_COMP)) {
+		*support = 0;
+		return 0;
+	}
+
+
+	return 0;
+}
+
+static void pci_configure_rp_10bit_tag(struct pci_dev *dev)
+{
+	u8 support = 1;
+	struct pci_dev *pchild;
+
+	if (dev->subordinate == NULL)
+		return;
+
+	/* If no devices under the root port,  no need to enable 10-Bit Tag. */
+	pchild = list_first_entry_or_null(&dev->subordinate->devices,
+					  struct pci_dev, bus_list);
+	if (pchild == NULL)
+		return;
+
+	pci_10bit_tag_comp_support(dev, &support);
+	if (!support)
+		return;
+
+	/*
+	 * PCIe spec 5.0r1.0 section 2.2.6.2 implementation note
+	 * In configurations where a Requester with 10-Bit Tag Requester capability
+	 * needs to target multiple Completers, one needs to ensure that the
+	 * Requester sends 10-Bit Tag Requests only to Completers that have 10-Bit
+	 * Tag Completer capability. So we enable 10-Bit Tag Requester for root port
+	 * only when the devices under the root port support 10-Bit Tag Completer.
+	 */
+	pci_walk_bus(dev->subordinate, pci_10bit_tag_comp_support, &support);
+	if (!support)
+		return;
+
+	if (!(dev->devcap2 & PCI_EXP_DEVCAP2_10BIT_TAG_REQ))
+		return;
+
+	pci_dbg(dev, "enabling 10-Bit Tag Requester\n");
+	pcie_capability_set_word(dev, PCI_EXP_DEVCTL2,
+				 PCI_EXP_DEVCTL2_10BIT_TAG_REQ_EN);
+}
+
 /*
  * pcie_portdrv_probe - Probe PCI-Express port devices
  * @dev: PCI-Express port device being probed
@@ -111,6 +184,9 @@ static int pcie_portdrv_probe(struct pci_dev *dev,
 	     (type != PCI_EXP_TYPE_RC_EC)))
 		return -ENODEV;
 
+	if (type == PCI_EXP_TYPE_ROOT_PORT)
+		pci_configure_rp_10bit_tag(dev);
+
 	if (type == PCI_EXP_TYPE_RC_EC)
 		pcie_link_rcec(dev);
 
-- 
2.7.4

Re: [PATCH V2 5/5] PCI: Enable 10-Bit tag support for PCIe RP devices

[Dongdong Liu]

This patch is based on the patchset [PATCH V2 0/5] PCI: Enable 10-Bit 
tag support for PCIe devices.

I use "git send-email" report "4.4.2 Message submission rate for this 
client has exceeded the configured limit" lead missed [PATCH V2 5/5].
Current I send the [PATCH V2 5/5] separately.
I have not figured out the "git send-email" issue :(. sometimes it's ok.

Thanks,
Dongdong
On 2021/5/11 23:12, Dongdong Liu wrote:
> PCIe spec 5.0r1.0 section 2.2.6.2 implementation note, In configurations
> where a Requester with 10-Bit Tag Requester capability needs to target
> multiple Completers, one needs to ensure that the Requester sends 10-Bit
> Tag Requests only to Completers that have 10-Bit Tag Completer capability.
> So we enable 10-Bit Tag Requester for root port only when the devices
> under the root port support 10-Bit Tag Completer.
>
> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
> ---
>  drivers/pci/pcie/portdrv_pci.c | 76 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 76 insertions(+)
>
> diff --git a/drivers/pci/pcie/portdrv_pci.c b/drivers/pci/pcie/portdrv_pci.c
> index c7ff1ee..19e6e62 100644
> --- a/drivers/pci/pcie/portdrv_pci.c
> +++ b/drivers/pci/pcie/portdrv_pci.c
> @@ -90,6 +90,79 @@ static const struct dev_pm_ops pcie_portdrv_pm_ops = {
>  #define PCIE_PORTDRV_PM_OPS	NULL
>  #endif /* !PM */
>
> +static int pci_10bit_tag_comp_support(struct pci_dev *dev, void *data)
> +{
> +	u8 *support = data;
> +
> +	if (*support == 0)
> +		return 0;
> +
> +	if (!pci_is_pcie(dev)) {
> +		*support = 0;
> +		return 0;
> +	}
> +
> +	/*
> +	 * PCIe spec 5.0r1.0 section 2.2.6.2 implementation note
> +	 * For configurations where a Requester with 10-Bit Tag Requester capability
> +	 * targets Completers where some do and some do not have 10-Bit Tag
> +	 * Completer capability, how the Requester determines which NPRs include
> +	 * 10-Bit Tags is outside the scope of this specification.  So we do not consider
> +	 * hotplug scenario.
> +	 */
> +	if (dev->is_hotplug_bridge) {
> +		*support = 0;
> +		return 0;
> +	}
> +
> +
> +	if (!(dev->devcap2 & PCI_EXP_DEVCAP2_10BIT_TAG_COMP)) {
> +		*support = 0;
> +		return 0;
> +	}
> +
> +
> +	return 0;
> +}
> +
> +static void pci_configure_rp_10bit_tag(struct pci_dev *dev)
> +{
> +	u8 support = 1;
> +	struct pci_dev *pchild;
> +
> +	if (dev->subordinate == NULL)
> +		return;
> +
> +	/* If no devices under the root port,  no need to enable 10-Bit Tag. */
> +	pchild = list_first_entry_or_null(&dev->subordinate->devices,
> +					  struct pci_dev, bus_list);
> +	if (pchild == NULL)
> +		return;
> +
> +	pci_10bit_tag_comp_support(dev, &support);
> +	if (!support)
> +		return;
> +
> +	/*
> +	 * PCIe spec 5.0r1.0 section 2.2.6.2 implementation note
> +	 * In configurations where a Requester with 10-Bit Tag Requester capability
> +	 * needs to target multiple Completers, one needs to ensure that the
> +	 * Requester sends 10-Bit Tag Requests only to Completers that have 10-Bit
> +	 * Tag Completer capability. So we enable 10-Bit Tag Requester for root port
> +	 * only when the devices under the root port support 10-Bit Tag Completer.
> +	 */
> +	pci_walk_bus(dev->subordinate, pci_10bit_tag_comp_support, &support);
> +	if (!support)
> +		return;
> +
> +	if (!(dev->devcap2 & PCI_EXP_DEVCAP2_10BIT_TAG_REQ))
> +		return;
> +
> +	pci_dbg(dev, "enabling 10-Bit Tag Requester\n");
> +	pcie_capability_set_word(dev, PCI_EXP_DEVCTL2,
> +				 PCI_EXP_DEVCTL2_10BIT_TAG_REQ_EN);
> +}
> +
>  /*
>   * pcie_portdrv_probe - Probe PCI-Express port devices
>   * @dev: PCI-Express port device being probed
> @@ -111,6 +184,9 @@ static int pcie_portdrv_probe(struct pci_dev *dev,
>  	     (type != PCI_EXP_TYPE_RC_EC)))
>  		return -ENODEV;
>
> +	if (type == PCI_EXP_TYPE_ROOT_PORT)
> +		pci_configure_rp_10bit_tag(dev);
> +
>  	if (type == PCI_EXP_TYPE_RC_EC)
>  		pcie_link_rcec(dev);
>
>

Re: [PATCH V2 5/5] PCI: Enable 10-Bit tag support for PCIe RP devices

[Christoph Hellwig]

On Tue, May 11, 2021 at 11:24:16PM +0800, Dongdong Liu wrote:
> This patch is based on the patchset [PATCH V2 0/5] PCI: Enable 10-Bit tag
> support for PCIe devices.
> 
> I use "git send-email" report "4.4.2 Message submission rate for this client
> has exceeded the configured limit" lead missed [PATCH V2 5/5].

That is a message from your mail server. Try tweaking the
sendemail.smtpBatchSize option in your .gitconfig

Re: [PATCH V2 5/5] PCI: Enable 10-Bit tag support for PCIe RP devices

[Dongdong Liu]

On 2021/5/11 23:31, Christoph Hellwig wrote:
> On Tue, May 11, 2021 at 11:24:16PM +0800, Dongdong Liu wrote:
>> This patch is based on the patchset [PATCH V2 0/5] PCI: Enable 10-Bit tag
>> support for PCIe devices.
>>
>> I use "git send-email" report "4.4.2 Message submission rate for this client
>> has exceeded the configured limit" lead missed [PATCH V2 5/5].
>
> That is a message from your mail server. Try tweaking the
> sendemail.smtpBatchSize option in your .gitconfig
> .
Thanks for you suggestion. It maybe my mail server issue,
change mail server addrees seems work ok.
>

Re: [PATCH V2 5/5] PCI: Enable 10-Bit tag support for PCIe RP devices

[Christoph Hellwig]

> +	/*
> +	 * PCIe spec 5.0r1.0 section 2.2.6.2 implementation note
> +	 * For configurations where a Requester with 10-Bit Tag Requester capability
> +	 * targets Completers where some do and some do not have 10-Bit Tag
> +	 * Completer capability, how the Requester determines which NPRs include
> +	 * 10-Bit Tags is outside the scope of this specification.  So we do not consider
> +	 * hotplug scenario.
> +	 */

Please avoid > 80 char lines that make comments completely unreadable.

Re: [PATCH V2 5/5] PCI: Enable 10-Bit tag support for PCIe RP devices

[Dongdong Liu]

On 2021/5/11 23:29, Christoph Hellwig wrote:
>> +	/*
>> +	 * PCIe spec 5.0r1.0 section 2.2.6.2 implementation note
>> +	 * For configurations where a Requester with 10-Bit Tag Requester capability
>> +	 * targets Completers where some do and some do not have 10-Bit Tag
>> +	 * Completer capability, how the Requester determines which NPRs include
>> +	 * 10-Bit Tags is outside the scope of this specification.  So we do not consider
>> +	 * hotplug scenario.
>> +	 */
>
> Please avoid > 80 char lines that make comments completely unreadable.
Thanks for pointing this, will fix.

Thanks,
Dongdong
> .
>