Re: [PATCH V4 2/4] PCI: Move loongson pci quirks to quirks.c

[Jiaxun Yang <jiaxun.yang@flygoat.com>]

在 2021/6/28 下午6:55, Huacai Chen 写道:
> Hi, Jiaxun,
>
> On Mon, Jun 28, 2021 at 6:41 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>>
>>
>> 在 2021/6/28 下午6:38, Huacai Chen 写道:
>>> Hi, Jiaxun,
>>>
>>> On Mon, Jun 28, 2021 at 6:13 PM Jiaxun Yang <jiaxun.yang@flygoat.com> wrote:
>>>>
>>>> 在 2021/6/28 下午6:10, Huacai Chen 写道:
>>>>> Loongson PCH (LS7A chipset) will be used by both MIPS-based and
>>>>> LoongArch-based Loongson processors. MIPS-based Loongson uses FDT
>>>>> but LoongArch-base Loongson uses ACPI, but the driver in drivers/
>>>>> pci/controller/pci-loongson.c is FDT-only. So move the quirks to
>>>>> quirks.c where can be shared by all architectures.
>>>>>
>>>>> LoongArch is a new RISC ISA, mainline support will come soon, and
>>>>> documentations are here (in translation):
>>>>>
>>>>> https://github.com/loongson/LoongArch-Documentation
>>>> Probably you should guard it with CONFIG_MACH_LOONGSON64 now and add
>>>> CONFIG_LOONGARCH
>>>> once LOONGARCH code is mainlined.
>>> These quirks won't match non-Loongson platforms (because they are
>>> matched by pci ids), so I think that is unnecessary.
>> Are you sure?
>> As I saw
>> +DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID
>> It will slow down boot progress on all systems.
> This ANY ID matching is only used by loongson_mrrs_quirk(), but the
> next patch will rework loongson_mrrs_quirk().

Oh I see. That seems better.

Thanks.

- Jiaxun

>
> Huacai
>