* [PATCH v1] perf test record.sh: Fix shellcheck warning
@ 2026-02-07 23:04 Ian Rogers
2026-02-08 14:27 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Ian Rogers @ 2026-02-07 23:04 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo, Namhyung Kim, Thomas Richter,
linux-perf-users, linux-kernel
Cc: Ian Rogers
Add quotes to avoid the following warning:
```
In tests/shell/record.sh line 264:
[ $(uname -m) = "s390x" ] && {
^---------^ SC2046 (warning): Quote this to prevent word splitting.
For more information:
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
```
Fixes: c73a56ed3c97 ("perf test: Fix test case Leader sampling on s390")
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/tests/shell/record.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
index 46b96d565680..7cb81cf3444a 100755
--- a/tools/perf/tests/shell/record.sh
+++ b/tools/perf/tests/shell/record.sh
@@ -261,7 +261,7 @@ test_uid() {
test_leader_sampling() {
echo "Basic leader sampling test"
events="{cycles,cycles}:Su"
- [ $(uname -m) = "s390x" ] && {
+ [ "$(uname -m)" = "s390x" ] && {
[ ! -d /sys/devices/cpum_sf ] && {
echo "No CPUMF [Skipped record]"
return
--
2.53.0.239.g8d8fc8a987-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v1] perf test record.sh: Fix shellcheck warning
2026-02-07 23:04 [PATCH v1] perf test record.sh: Fix shellcheck warning Ian Rogers
@ 2026-02-08 14:27 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2026-02-08 14:27 UTC (permalink / raw)
To: Ian Rogers; +Cc: Namhyung Kim, Thomas Richter, linux-perf-users, linux-kernel
On Sat, Feb 07, 2026 at 03:04:52PM -0800, Ian Rogers wrote:
> Add quotes to avoid the following warning:
> ```
> In tests/shell/record.sh line 264:
> [ $(uname -m) = "s390x" ] && {
> ^---------^ SC2046 (warning): Quote this to prevent word splitting.
>
> For more information:
> https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
> ```
>
> Fixes: c73a56ed3c97 ("perf test: Fix test case Leader sampling on s390")
Thanks, applied to perf-tools-next,
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google.com>
> ---
> tools/perf/tests/shell/record.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/shell/record.sh b/tools/perf/tests/shell/record.sh
> index 46b96d565680..7cb81cf3444a 100755
> --- a/tools/perf/tests/shell/record.sh
> +++ b/tools/perf/tests/shell/record.sh
> @@ -261,7 +261,7 @@ test_uid() {
> test_leader_sampling() {
> echo "Basic leader sampling test"
> events="{cycles,cycles}:Su"
> - [ $(uname -m) = "s390x" ] && {
> + [ "$(uname -m)" = "s390x" ] && {
> [ ! -d /sys/devices/cpum_sf ] && {
> echo "No CPUMF [Skipped record]"
> return
> --
> 2.53.0.239.g8d8fc8a987-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-08 14:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-07 23:04 [PATCH v1] perf test record.sh: Fix shellcheck warning Ian Rogers
2026-02-08 14:27 ` Arnaldo Carvalho de Melo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox