Re: [PATCH 3/5] perf trace: Sync uapi/linux/mount.h with the kernel source

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit syncs `uapi/linux/mount.h` to pick up the `FSMOUNT_NAMESPACE` flag, with the commit message explicitly claiming "This would be used to beautify mount syscall arguments". However, unlike `MOUNT_ATTR_*` flags which are automatically parsed by `tools/perf/trace/beauty/fsmount.sh`, the `FSMOUNT_*` flags are strictly hardcoded in `tools/perf/builtin-trace.c` (`static const char *fsmount_flags[] = { [1] = "CLOEXEC", };`). Because `[2] = "NAMESPACE"` was not manually added to this array, the new flag will not be beautified.
--

commit 41bba49a1df4092fb9de0814ee5b9c785fd42578
Author: Namhyung Kim <namhyung@kernel.org>

perf trace: Sync uapi/linux/mount.h with the kernel source

This commit syncs the uapi/linux/mount.h header to pick up the new
FSMOUNT_NAMESPACE flag.

> diff --git a/tools/perf/trace/beauty/include/uapi/linux/mount.h b/tools/perf/trace/beauty/include/uapi/linux/mount.h
> index d9d86598d100..2204708dbf7a 100644
> --- a/tools/perf/trace/beauty/include/uapi/linux/mount.h
> +++ b/tools/perf/trace/beauty/include/uapi/linux/mount.h
> @@ -110,6 +110,7 @@ enum fsconfig_command {
>   * fsmount() flags.
>   */
>  #define FSMOUNT_CLOEXEC		0x00000001
> +#define FSMOUNT_NAMESPACE	0x00000002	/* Create the mount in a new mount namespace */

The commit message states: "This would be used to beautify mount syscall
arguments". Will this header sync be enough to beautify the new flag?

Looking at tools/perf/builtin-trace.c, the fsmount_flags array is manually
hardcoded:

static const char *fsmount_flags[] = {
        [1] = "CLOEXEC",
};

Since [2] = "NAMESPACE" is not present in this array, ARRAY_SIZE(fsmount_flags)
remains 2. The loop in strarray__scnprintf_flags() checks up to index 1.

Does the FSMOUNT_NAMESPACE flag also need to be manually added to the
fsmount_flags array in builtin-trace.c for the beautification to work?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260503193137.27465-1-namhyung@kernel.org?part=3