Re: [PATCH 4/5] perf trace: Sync uapi/linux/sched.h with the kernel source

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `clone.sh` beautification script fails to parse the new `(1ULL << X)` format for `CLONE_` macros, resulting in missing syscall argument translations in `perf trace`.
--

commit 21b4f549d315112f3b383339c5af0152f585767e
Author: Namhyung Kim <namhyung@kernel.org>

perf trace: Sync uapi/linux/sched.h with the kernel source

This commit synchronizes the tools/perf uapi sched.h with the kernel source
to pick up new clone flags for beautifying scheduler syscall arguments.

> diff --git a/tools/perf/trace/beauty/include/uapi/linux/sched.h b/tools/perf/trace/beauty/include/uapi/linux/sched.h
> index 359a14cc76a4..33a4624285cd 100644
> --- a/tools/perf/trace/beauty/include/uapi/linux/sched.h
> +++ b/tools/perf/trace/beauty/include/uapi/linux/sched.h
> @@ -34,8 +34,12 @@
>  #define CLONE_IO		0x80000000	/* Clone io context */
>  
>  /* Flags for the clone3() syscall. */
> -#define CLONE_CLEAR_SIGHAND 0x100000000ULL /* Clear any signal handler and reset to SIG_DFL. */
> -#define CLONE_INTO_CGROUP 0x200000000ULL /* Clone into a specific cgroup given the right permissions. */
> +#define CLONE_CLEAR_SIGHAND	(1ULL << 32) /* Clear any signal handler and reset to SIG_DFL. */
> +#define CLONE_INTO_CGROUP	(1ULL << 33) /* Clone into a specific cgroup given the right permissions. */
> +#define CLONE_AUTOREAP		(1ULL << 34) /* Auto-reap child on exit. */
> +#define CLONE_NNP		(1ULL << 35) /* Set no_new_privs on child. */
> +#define CLONE_PIDFD_AUTOKILL	(1ULL << 36) /* Kill child when clone pidfd closes. */
> +#define CLONE_EMPTY_MNTNS	(1ULL << 37) /* Create an empty mount namespace. */

Will this format change cause a regression in the clone flags beautifier?

Looking at tools/perf/trace/beauty/clone.sh, it uses a regular expression
expecting hexadecimal values to extract the flags: (0x[[:xdigit:]]+).

Because these updated macros now use a bitwise shift format instead of hex
values, they might be silently ignored by the script during parsing. This
would result in perf trace failing to translate these flags, printing raw
numeric values instead.

Does the regex in clone.sh also need to be updated to handle the new
format?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260503193137.27465-1-namhyung@kernel.org?part=4