Re: [PATCH 5/5] perf build: Add make check-headers target

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `tools/include/uapi/README` documentation was not updated to reflect the removal of the automated header synchronization check.
- [Low] The new `check-headers` target in `tools/perf/Makefile` is missing a `.PHONY` declaration.
--

commit dd1cd2c298920f9790f61d618060d62047bed876
Author: Namhyung Kim <namhyung@kernel.org>

perf build: Add make check-headers target

This commit removes the automated check-headers.sh script execution from
the default perf build and adds a dedicated check-headers Make target to
be called manually instead.

> As it's to improve perf trace beautifier to catch up new changes mostly
> in UAPIs, we can make it a separate build target and call it
> occasionally.

Does this change require an update to tools/include/uapi/README?

The README currently documents a "software-enforced copy-on-write mechanism"
that is "driven by non-fatal warnings on the tooling side build." 

Since this is no longer automated during routine builds, developers might miss
UAPI changes if they rely on the currently documented behavior.

> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile

[ ... ]

> @@ -111,6 +111,9 @@ build-test:
>  build-test-tarball:
>  	@$(MAKE) -f tests/make REUSE_FEATURES_DUMP=1 MK=Makefile SET_PARALLEL=1 --no-print-directory out
>  
> +check-headers:
> +	@./check-headers.sh
> +

Should check-headers be added to the .PHONY declarations?

Since check-headers is a command target and does not produce an artifact by
that name, if a file or directory named check-headers is ever created in
tools/perf/, Make will consider the target up to date and silently skip
executing the script.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260503193137.27465-1-namhyung@kernel.org?part=5