Re: [PATCH v9 4/5] perf test: Add inject ASLR test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Double execution of the cleanup function on script termination.
--

commit 15a772bdaa14c7c9486c156f196dc344720b9656
Author: Ian Rogers <irogers@google.com>

perf test: Add inject ASLR test

Add a new shell test to verify the feature. The test covers basic address
remapping for user space samples, pipe mode coverage, callchain address
remapping, report consistency, and kernel address remapping.

> diff --git a/tools/perf/tests/shell/inject_aslr.sh b/tools/perf/tests/shell/inject_aslr.sh
> new file mode 100755
> index 0000000000000..ea0db1d5faf9b
> --- /dev/null
> +++ b/tools/perf/tests/shell/inject_aslr.sh

[ ... ]

> +cleanup() {
> +  local exit_code=$?
> +  if [ "${exit_code}" -ne 0 ] || [ "${err}" -ne 0 ]; then
> +    echo "Test failed! Preserving temp directory: ${temp_dir}"
> +    return
> +  fi
> +  # Check if temp_dir is set and looks sane before removing
> +  if [[ "${temp_dir}" =~ ^/tmp/perf-test-aslr\. ]]; then
> +    rm -rf "${temp_dir}"
> +  fi
> +}
> +
> +trap_cleanup() {
> +  exit 1
> +}
> +
> +trap cleanup EXIT
> +trap trap_cleanup TERM INT

[ ... ]

> +test_kernel_report_aslr
> +
> +cleanup
> +exit $err

[Severity: Low]
Does this code execute the cleanup function twice? The script registers
cleanup on the EXIT trap, but explicitly calls it here right before exit.
If a test fails, could this result in the failure message being printed twice,
or if tests succeed, might it attempt to remove the temporary directory
a second time?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260604172850.683329-1-irogers@google.com?part=4