Re: [PATCH v2 05/16] perf synthetic-events: Fix uninitialized pthread_join

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Low] Missing explicit POSIX inclusions for <stdlib.h> and <pthread.h> in synthetic-events.c.
--

commit 9ead28d76c34623188955779076a3c283fe73884
Author: Ian Rogers <irogers@google.com>

perf synthetic-events: Fix uninitialized pthread_join

This commit fixes an uninitialized pthread_join() call in
perf_event__synthesize_threads() when thread creation fails. It updates the
cleanup loop to only join the threads that were successfully created.

> diff --git a/tools/perf/util/synthetic-events.c b/tools/perf/util/synthetic-events.c
> --- a/tools/perf/util/synthetic-events.c
> +++ b/tools/perf/util/synthetic-events.c
> @@ -1104,8 +1104,8 @@ int perf_event__synthesize_threads(const struct perf_tool *tool,
>  	}
>  	err = 0;
>  out_join:
> -	for (i = 0; i < thread_nr; i++)
> -		pthread_join(synthesize_threads[i], NULL);
> +	for (j = 0; j < i; j++)
> +		pthread_join(synthesize_threads[j], NULL);

[Severity: Low]
This is a pre-existing issue, but should this file have explicit POSIX header
inclusions for <stdlib.h> and <pthread.h> to ensure compatibility with musl
libc? The code here relies on pthread_join() and free(), but appears to
depend on implicit header inclusions to resolve them.

>  	free(args);
>  free_threads:
>  	free(synthesize_threads);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260624051535.3584977-1-irogers@google.com?part=5