Re: [PATCH v2 07/16] perf test: Fix skiplist leak in cmd_test

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Unsafe error handling: `errno` may be clobbered by cleanup functions before being evaluated.
--

commit c1a33a510193529b900f698c55a9892c973edeb2
Author: Ian Rogers <irogers@google.com>

perf test: Fix skiplist leak in cmd_test

This commit fixes a memory leak in cmd_test() by ensuring the skiplist is
properly freed on the exit paths.

> diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-test.c
> index 7e75f590f225e..cf5625cf4f110 100644
> --- a/tools/perf/tests/builtin-test.c
> +++ b/tools/perf/tests/builtin-test.c

[ ... ]

> @@ -1781,9 +1781,12 @@ int cmd_test(int argc, const char **argv)
>  	rlimit__bump_memlock();
>  
>  	suites = build_suites();
> -	if (!suites)
> +	if (!suites) {
> +		intlist__delete(skiplist);
>  		return errno ? -errno : -ENOMEM;

[Severity: Medium]
Could the call to intlist__delete() clobber errno before it is evaluated in
the return statement? 

intlist__delete() cascades to rblist__delete(), which ultimately issues
free() calls. On some libc implementations or under memory sanitizers, free()
and related cleanup functions do not guarantee that errno is preserved. This
could result in returning an incorrect error code from build_suites().

> +	}
>  	ret = __cmd_test(suites, argc, argv, skiplist);
>  	free(suites);
> +	intlist__delete(skiplist);
>  	return ret;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260624051535.3584977-1-irogers@google.com?part=7