Re: [PATCH v3 05/14] perf stat: Extend STD output linter to test advanced PMU checks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added test for `--per-cluster` silently succeeds without actually validating the standard console output, rendering the test case ineffective and contradicting the commit's claims.
--

--- Patch [5]: [PATCH v3 05/14] perf stat: Extend STD output linter to test advanced PMU checks ---
commit 6ca9850895a48d9a46d217a2535f3b76f2a6f0f3
Author: Ian Rogers <irogers@google.com>

perf stat: Extend STD output linter to test advanced PMU checks

This patch adds check_per_cache_instance and check_per_cluster to the
stat+std_output.sh test script. This is intended to ensure that standard
console outputs are verified under advanced topology-aware aggregation
environments.

> diff --git a/tools/perf/tests/shell/stat+std_output.sh b/tools/perf/tests/shell/stat+std_output.sh
> index 8dee005a72816..0d38a12839670 100755
> --- a/tools/perf/tests/shell/stat+std_output.sh
> +++ b/tools/perf/tests/shell/stat+std_output.sh
> @@ -131,6 +131,8 @@ then
>  	check_per_core "STD (New API)" "$perf_cmd"
>  	check_per_die "STD (New API)" "$perf_cmd"
>  	check_per_socket "STD (New API)" "$perf_cmd"
> +	check_per_cache_instance "STD (New API)" "$perf_cmd"
> +	check_per_cluster "STD (New API)" "$perf_cmd"

[Severity: Medium]
Will this actually verify the output as described in the commit message?

Looking at the preexisting definition of check_per_cluster() in
tools/perf/tests/shell/lib/stat_output.sh:

check_per_cluster()
{
	echo -n "Checking $1 output: per cluster "
	if ParanoidAndNotRoot 0
	then
		echo "[Skip] paranoid and not root"
		return
	fi
	perf stat --per-cluster -a $2 true
	echo "[Success]"
}

It appears to be missing the commachecker --per-cluster validation step found
in other check functions.

Without the commachecker call, does this test silently pass without
validating the output?

>  fi
>  
>  cleanup

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716043223.388233-1-irogers@google.com?part=5