Re: [PATCH v6 05/10] perf disasm: Fix potential NULL pointer dereference and use-after-free in arch__find()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Low] Missing explicit inclusions of POSIX standard headers `<stdio.h>`, `<limits.h>`, and `<string.h>`.
--

--- Patch [5]: [PATCH v6 05/10] perf disasm: Fix potential NULL pointer dereference and use-after-free in arch__find() ---
commit ca1fd445ff68f5d4f2326b24e16c260e3dc0cb4f
Author: Ian Rogers <irogers@google.com>

perf disasm: Fix potential NULL pointer dereference and use-after-free in arch__find()

This commit fixes a NULL pointer dereference in the error path of
arch__find() by printing the e_machine ID instead of the uninitialized
name. It also prevents a use-after-free by correctly updating the global
archs pointer immediately after successfully reallocating memory.

Closes: https://lore.kernel.org/linux-perf-users/20260709035721.9EE901F000E9@smtp.kernel.org/

> diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c
> index 0a1a7e9cf3efe..6cfdbabbb8c7d 100644
> --- a/tools/perf/util/disasm.c
> +++ b/tools/perf/util/disasm.c

[Severity: Low]
This isn't a bug introduced by this patch, but there is a pre-existing
issue in the include block at the top of tools/perf/util/disasm.c.

Because musl libc strictly separates declarations unlike glibc, missing
explicit inclusions of POSIX standard headers such as <stdio.h>, <limits.h>,
and <string.h> can cause compilation failures when building the perf tool
in a musl environment.

Could we add these explicit headers at the top of the file to ensure
consistent musl compatibility during the build?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716072351.560311-1-irogers@google.com?part=5