Re: [PATCH v3 01/14] perf c2c: extract shared data structures into c2c.h

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The header file `c2c.h` conditionally declares `perf_c2c__browse_cacheline` under `#ifdef HAVE_SLANG_SUPPORT` but fails to provide a dummy fallback stub in an `#else` block.
--

--- Patch [1]: [PATCH v3 01/14] perf c2c: extract shared data structures into c2c.h ---
commit 80edfe9d884de7c391eedef4197115fd44418382
Author: Jiebin Sun <jiebin.sun@intel.com>

perf c2c: extract shared data structures into c2c.h

This commit moves c2c data structures from builtin-c2c.c into a new shared 
header c2c.h to allow reuse by the upcoming function view browser. It also 
makes the global perf_c2c instance non-static and exports 
perf_c2c__browse_cacheline().

> diff --git a/tools/perf/c2c.h b/tools/perf/c2c.h
> new file mode 100644
> index 0000000000000..79dbd35184eda
> --- /dev/null
> +++ b/tools/perf/c2c.h

[ ... ]

> +void *c2c_he_zalloc(size_t size);
> +void c2c_fmt_free(struct perf_hpp_fmt *fmt);
> +bool c2c_fmt_equal(struct perf_hpp_fmt *a, struct perf_hpp_fmt *b);
> +
> +#ifdef HAVE_SLANG_SUPPORT
> +int perf_c2c__browse_cacheline(struct hist_entry *he);

[Severity: Medium]
Since perf_c2c__browse_cacheline() is conditionally declared under 
HAVE_SLANG_SUPPORT, should there be a dummy inline fallback stub provided 
in an #else block?

Without a fallback stub, any C code calling this function would either fail 
to compile when slang support is absent, or require redundant #ifdef 
HAVE_SLANG_SUPPORT guards at every call site.

> +#endif
> +
> +#endif /* _PERF_C2C_H_ */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717020530.1645123-1-jiebin.sun@intel.com?part=1