Re: [RFC v1 06/19] ptwrite uprobes: Add a sample module to exercise interface

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Hardcoded local developer path in Makefile comment.
--

commit 6f339cbb02cf7327f16d076027733bac7f4b2900
Author: Andi Kleen <ak@kernel.org>

ptwrite uprobes: Add a sample module to exercise interface

This commit adds a basic test module and a test program for uprobes ptwrite.
It provides an interface to configure and register a ptwrite uprobe in an
executable for testing purposes.

> diff --git a/samples/uprobe-ptwrite/Makefile b/samples/uprobe-ptwrite/Makefile
> new file mode 100644
> index 0000000000000..086d84be6ad2e
> --- /dev/null
> +++ b/samples/uprobe-ptwrite/Makefile
> @@ -0,0 +1,13 @@
[ ... ]
> +#
> +# The userspace test target (test_prog) is built by the out-of-tree test
> +# harness (see /home/oc/uprobe-ptwrite-test); the harness computes the file

[Severity: Low]
This isn't a bug, but is this local path (/home/oc/uprobe-ptwrite-test)
intended to be included in the upstream kernel source? It appears to be a
local developer directory rather than a path that would be accessible to
other developers.

> +# offset of target()'s 5-byte NOP and passes it to the module's offset
> +# parameter.
> +
> +obj-$(CONFIG_SAMPLE_UPROBE_PTWRITE) += uprobe_ptwrite_test.o

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831150651.1134594-1-ak@kernel.org?part=6