Re: [PATCH 6/9] perf build: Use the given CC rather than clang in clang builds

[sashiko-bot@kernel.org]

> The clang block is entered when CC_NO_CLANG has determined that CC is
> clang, but it then ignores CC and hard codes $(CLANG), which defaults to
> plain "clang". Building with a versioned compiler silently switches
> compiler:
> 
>   $ make CC=clang-19		# actually builds with "clang"
> 
> Worse, the target triple is probed with $(CLANG) too, so on a machine
> that only has versioned binaries installed the probe produces nothing
> and the build stops:
> 
>   $ make CC=clang-19
>   *** Specify CROSS_COMPILE or add CLANG_TARGET_FLAGS for x86_64
> 
> Use $(CC) in both places. Within the block CC is known to be clang, and
> for "make LLVM=1" CC is already $(CLANG), so nothing changes there.
> 
> $(CLANG) is left as it is for BPF skeletons, as bpf_skel.mak builds
> those with "$(CLANG) --target=bpf" whatever CC happens to be.
> 
> Fixes: 4772e66cb45e ("perf build: Support build with clang")
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916061218.3061216-1-irogers@google.com?part=6