Re: [PATCH 2/9] perf symbol: Fix the build when demangling with libbfd

[sashiko-bot@kernel.org]

> cxx_demangle_sym() calls bfd_demangle() with the DMGL_PARAMS and
> DMGL_ANSI flags, but nothing declares them. The
> "#define PACKAGE 'perf'", "#include <bfd.h>" and the DMGL_ definitions
> were left behind in symbol-elf.c when the demangling code moved to
> symbol.c, and libiberty's demangle.h that defines the flags isn't
> installed by every binutils package. The cplus_demangle() variant is
> missing a declaration for the same reason.
> 
> The code is only built when the C++ ABI's __cxa_demangle() is
> unavailable, so most builds never compile it:
> 
>   $ make BUILD_NONDISTRO=1 NO_DEMANGLE=1
>   util/symbol.c:2714: error: 'DMGL_PARAMS' undeclared
>   util/symbol.c:2714: error: 'DMGL_ANSI' undeclared
>   util/symbol.c:2716: error: implicit declaration of 'bfd_demangle'
> 
> Move the libbfd demangling into libbfd.c, which already includes bfd.h,
> and declare in symbol.c the libiberty interfaces the cplus_demangle()
> variant needs.
> 
> Fixes: 4d9b5146f0d9 ("perf symbol: Move demangling code out of symbol-elf.c")
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916061218.3061216-1-irogers@google.com?part=2