From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 9/9] perf test: Add build tests for clang and libbfd demangling
Date: Wed, 16 Sep 2026 06:22:33 +0000 [thread overview]
Message-ID: <20260916062233.B86651F00899@smtp.kernel.org> (raw)
In-Reply-To: <20260916061218.3061216-10-irogers@google.com>
> Three build configurations broke recently without the build test suite
> noticing, as none of them were covered:
>
> - "CC=clang" on its own. CXX is only set to clang++ by "make LLVM=1",
> so CXX stays as g++ and used to be passed clang's flags.
> - "CC=clang BUILD_NONDISTRO=1", where libbfd.c failed clang's
> -Wthread-safety analysis.
> - "BUILD_NONDISTRO=1 NO_DEMANGLE=1", the only combination that
> compiles the libbfd demangling in symbol.c, which referred to
> identifiers nothing declared.
>
> Add the three. The clang ones need clang installed, and the libbfd ones
> reuse the existing binutils check.
>
> Testing that perf was built isn't enough for the first one. Feature
> [ ... ]
>
> For the same reason the clang tests must not reuse a feature dump made
> with the default compiler, so exclude them from REUSE_FEATURES_DUMP.
>
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260916061218.3061216-1-irogers@google.com?part=9
next prev parent reply other threads:[~2026-09-16 6:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 6:12 [PATCH 0/9] perf build: Fix builds with clang and BUILD_NONDISTRO Ian Rogers
2026-09-16 6:12 ` [PATCH 1/9] perf libbfd: Fix the clang -Wthread-safety build failure Ian Rogers
2026-09-16 6:18 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 2/9] perf symbol: Fix the build when demangling with libbfd Ian Rogers
2026-09-16 6:21 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 3/9] perf libbfd: Include the headers that are used Ian Rogers
2026-09-16 6:22 ` sashiko-bot
2026-09-16 15:54 ` Ian Rogers
2026-09-16 17:37 ` Namhyung Kim
2026-09-16 6:12 ` [PATCH 4/9] perf pmu: " Ian Rogers
2026-09-16 6:14 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 5/9] perf build: Only pass clang flags to CXX when CXX is clang Ian Rogers
2026-09-16 6:17 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 6/9] perf build: Use the given CC rather than clang in clang builds Ian Rogers
2026-09-16 6:19 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 7/9] perf build: Check the version of the compiler that is used Ian Rogers
2026-09-16 6:16 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 8/9] perf build: Remove leftovers of removed build options Ian Rogers
2026-09-16 6:17 ` sashiko-bot
2026-09-16 6:12 ` [PATCH 9/9] perf test: Add build tests for clang and libbfd demangling Ian Rogers
2026-09-16 6:22 ` sashiko-bot [this message]
2026-09-16 17:35 ` [PATCH 0/9] perf build: Fix builds with clang and BUILD_NONDISTRO Namhyung Kim
2026-09-22 12:47 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260916062233.B86651F00899@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox