Re: [PATCH v3 3/3] perf libbfd: Report success when an address is found

[sashiko-bot@kernel.org]

> libbfd__addr2line() only reports success when the caller asked for a file
> name. addr2inlines() passes a NULL file as it just wants the inline_node
> populating, so libbfd__addr2line() returns 0 for it unless
> bfd_find_inliner_info() happened to find an inline frame. addr2line() in
> srcline.c treats 0 as a failure and tries the next addr2line
> implementation, which appends its own frames to the inline_node libbfd
> already appended to. Every frame that isn't inlined is then reported
> twice, which happens by default when perf is built with libbfd but
> without libdw as the fallback order is then libbfd followed by the
> addr2line command:
> 
>   $ perf record --call-graph dwarf -- perf test -w inlineloop 1
>   $ perf script --fields +srcline
>   ...
> 	    56051a994f8e parent+0x2e (perf)
> [ ... ]
> does, and clear the frames appended so far when appending fails so that a
> following implementation starts from an empty node.
> 
> Fixes: 257046a36750 ("perf srcline: Fallback between addr2line implementations")
> Signed-off-by: Ian Rogers <irogers@google.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916234402.437113-1-irogers@google.com?part=3