Re: [PATCH v3 2/3] perf dso: Separate libbfd and cmd addr2line caches to fix confusion

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] perf: redundant duplicate include of dso.h
--

commit 44eae5fccba5e70d2ae1177b6b716c83f9242611
Author: Ian Rogers <irogers@google.com>

perf dso: Separate libbfd and cmd addr2line caches to fix confusion

This commit separates the libbfd and command-line addr2line caches in the
dso struct to prevent type confusion during fallback. By splitting the
caches, it avoids casting a2l_data into child_process, which previously
caused arbitrary instruction address coercion and silent aborts.

> diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c
> index df39e6ca88e6a..6510767177be5 100644
> --- a/tools/perf/util/dso.c
> +++ b/tools/perf/util/dso.c
> @@ -1,38 +1,45 @@
>  // SPDX-License-Identifier: GPL-2.0
> +#include "dso.h"
> +
> +#include <errno.h>
> +#include <stdlib.h>
> +
>  #include <asm/bug.h>
> +#include <fcntl.h>

[ ... ]

>  #include "compress.h"
> +#include "debug.h"
> +#include "dso.h"

[Severity: Low]
Is this second inclusion of dso.h intentional?

The patch already adds an include for "dso.h" at the very top of
tools/perf/util/dso.c, so this results in a redundant duplicate include
remaining in the alphabetical block.

> +#include "dsos.h"
>  #include "env.h"
>  #include "namespaces.h"
>  #include "path.h"

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260916234402.437113-1-irogers@google.com?part=2