From: sashiko-bot@kernel.org
To: "Ian Rogers" <irogers@google.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v4 2/3] perf dso: Separate libbfd and cmd addr2line caches to fix confusion
Date: Thu, 17 Sep 2026 05:12:55 +0000 [thread overview]
Message-ID: <20260917051256.196E01F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260917050450.703018-3-irogers@google.com>
> When a dso executes addr2line via libbfd it instantiates an a2l_data
> pointer. If the DSO later executes via the command-line fallback due
> to an inlined bug, the a2l pointer is unconditionally populated with a
> child_process process wrapper. If libbfd is queried again, the offline
> reader attempts to cast struct a2l_data into child_process, coercing
> random arbitrary instruction addresses and causing silent aborts. This
> cleanly splits the caches.
>
> Fixes: 257046a36750 ("perf srcline: Fallback between addr2line implementations")
> Signed-off-by: Ian Rogers <irogers@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260917050450.703018-1-irogers@google.com?part=2
next prev parent reply other threads:[~2026-09-17 5:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 17:07 [PATCH v1 1/2] perf libdw: Fix Dwfl discovery with split files Ian Rogers
2026-09-14 17:07 ` [PATCH v1 2/2] perf dso: Separate libbfd and cmd addr2line caches to fix confusion Ian Rogers
2026-09-14 17:24 ` sashiko-bot
2026-09-14 17:30 ` [PATCH v1 1/2] perf libdw: Fix Dwfl discovery with split files sashiko-bot
2026-09-16 6:35 ` [PATCH v2 0/3] perf srcline: Fix addr2line cache and fallback bugs Ian Rogers
2026-09-16 6:35 ` [PATCH v2 1/3] perf libdw: Fix Dwfl discovery with split files Ian Rogers
2026-09-16 6:52 ` sashiko-bot
2026-09-16 6:35 ` [PATCH v2 2/3] perf dso: Separate libbfd and cmd addr2line caches to fix confusion Ian Rogers
2026-09-16 6:47 ` sashiko-bot
2026-09-16 6:35 ` [PATCH v2 3/3] perf libbfd: Report success when an address is found Ian Rogers
2026-09-16 6:47 ` sashiko-bot
2026-09-16 23:43 ` [PATCH v3 0/3] perf srcline: Fix addr2line cache and fallback bugs Ian Rogers
2026-09-16 23:44 ` [PATCH v3 1/3] perf libdw: Fix Dwfl discovery with split files Ian Rogers
2026-09-17 0:03 ` sashiko-bot
2026-09-16 23:44 ` [PATCH v3 2/3] perf dso: Separate libbfd and cmd addr2line caches to fix confusion Ian Rogers
2026-09-16 23:54 ` sashiko-bot
2026-09-16 23:44 ` [PATCH v3 3/3] perf libbfd: Report success when an address is found Ian Rogers
2026-09-16 23:54 ` sashiko-bot
2026-09-17 5:04 ` [PATCH v4 0/3] perf srcline: Fix addr2line cache and fallback bugs Ian Rogers
2026-09-17 5:04 ` [PATCH v4 1/3] perf libdw: Fix Dwfl discovery with split files Ian Rogers
2026-09-17 5:20 ` sashiko-bot
2026-09-17 5:04 ` [PATCH v4 2/3] perf dso: Separate libbfd and cmd addr2line caches to fix confusion Ian Rogers
2026-09-17 5:12 ` sashiko-bot [this message]
2026-09-17 5:04 ` [PATCH v4 3/3] perf libbfd: Report success when an address is found Ian Rogers
2026-09-17 5:16 ` sashiko-bot
2026-09-18 20:25 ` [PATCH v3 0/3] perf srcline: Fix addr2line cache and fallback bugs Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260917051256.196E01F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=irogers@google.com \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox