Linux Perf Users
 help / color / mirror / Atom feed
From: TAKANO Mitsuhiro <takano32@gmail.com>
To: linux-perf-users@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	Ilkka Koskinen <ilkka@os.amperecomputing.com>,
	John Garry <john.garry@linux.dev>,
	TAKANO Mitsuhiro <takano32@gmail.com>
Subject: [PATCH] perf vendor events arm64 AmpereOneX: Drop stale BPU_FLUSH_MEM_FAULT entry
Date: Wed, 21 Oct 2026 22:45:27 +0000	[thread overview]
Message-ID: <20261021224527.167637-1-takano32@gmail.com> (raw)

AmpereOne carried BPU_FLUSH_MEM_FAULT for EventCode 0x121 until it was
renamed to GPC_FLUSH_MEM_FAULT in 10a149e4b4a9; that rename and the
AmpereOneX table were patches 3 and 4 of the same series, so the new file
kept the old name.

The result is a table that names the 0x121 counter twice:
ampereonex/core-imp-def.json has GPC_FLUSH_MEM_FAULT, and
ampereonex/memory.json adds BPU_FLUSH_MEM_FAULT with the same code and
the same description.  On AmpereOneX perf therefore lists two events for
one counter, one of them under a name the documentation does not use.
No metric and no other file refers to either name, so removing the stale
entry cannot change a metric.

It also leaves memory.json holding only the ArchStdEvent aliases the
other files of that kind carry: AmpereOne's memory.json has no raw
EventCode at all, and neither has any other file of the AmpereOneX set
except the ones where raw codes belong.

Nothing catches this at build time.  jevents.py asserts on duplicate
event names, but x86 repeats an EventCode for many events because the
code carries umask and unit bits (3756 times across its tables) and
powerpc repeats five codes, so a duplicate-code check is not possible.
arm64 is the only architecture where no table but this one repeats a
code.

Not tested on hardware: there is no AmpereOneX machine here, so perf was
not run against the real PMU.  The change only edits a JSON table; the
perf build was verified and the generated table for this PMU goes from
two names for 0x121 to one (rebuilt, counted in pmu-events.c).

Fixes: 16438b652b46 ("perf vendor events arm64 AmpereOneX: Add core PMU events and metrics")
Assisted-by: LLM
Signed-off-by: TAKANO Mitsuhiro <takano32@gmail.com>
---
 .../pmu-events/arch/arm64/ampere/ampereonex/memory.json     | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/memory.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/memory.json
index 6c06bc928415..2a83782f51b0 100644
--- a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/memory.json
+++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/memory.json
@@ -33,11 +33,5 @@
     },
     {
         "ArchStdEvent": "MEM_ACCESS_CHECKED_WR"
-    },
-    {
-        "PublicDescription": "Flushes due to memory hazards",
-        "EventCode": "0x121",
-        "EventName": "BPU_FLUSH_MEM_FAULT",
-        "BriefDescription": "Flushes due to memory hazards"
     }
 ]

base-commit: f47d223627f80cb7a1eb14c585fe6cb35de5e984
-- 
2.53.0


             reply	other threads:[~2026-10-21 22:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21 22:45 TAKANO Mitsuhiro [this message]
2026-10-21 22:48 ` [PATCH] perf vendor events arm64 AmpereOneX: Drop stale BPU_FLUSH_MEM_FAULT entry sashiko-bot
2026-10-27 20:34 ` Arnaldo Carvalho de Melo
2026-10-27 21:37   ` Ian Rogers
2026-10-29  1:09     ` Ilkka Koskinen
2026-10-30  5:37     ` TAKANO Mitsuhiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261021224527.167637-1-takano32@gmail.com \
    --to=takano32@gmail.com \
    --cc=acme@kernel.org \
    --cc=ilkka@os.amperecomputing.com \
    --cc=irogers@google.com \
    --cc=john.garry@linux.dev \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox