Linux Perf Users
 help / color / mirror / Atom feed
From: "Mi, Dapeng" <dapeng1.mi@linux.intel.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [Patch v9 03/10] tools headers: Sync x86 headers with kernel sources
Date: Wed, 8 Jul 2026 10:05:57 +0800	[thread overview]
Message-ID: <83893ff1-cc40-45dd-a14f-4ce6f66bcc4b@linux.intel.com> (raw)
In-Reply-To: <20260706025423.D60241F000E9@smtp.kernel.org>


On 7/6/2026 10:54 AM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Modifying a tools header without a corresponding kernel header update causes a synchronization divergence and triggers build warnings.
> --
>
> commit f29e894bc895095793a45b66351922174d49d6a4
> Author: Dapeng Mi <dapeng1.mi@linux.intel.com>
>
> tools headers: Sync x86 headers with kernel sources
>
> This commit attempts to synchronize the x86 msr-index.h header in the
> tools directory with the kernel sources by adding ARCH_PEBS_VECR_xxx
> macros.
>
>> diff --git a/tools/arch/x86/include/asm/msr-index.h b/tools/arch/x86/include/asm/msr-index.h
>> index eff29645719bc..8cbc4c4997065 100644
>> --- a/tools/arch/x86/include/asm/msr-index.h
>> +++ b/tools/arch/x86/include/asm/msr-index.h
>> @@ -350,6 +350,13 @@
>>  #define ARCH_PEBS_LBR_SHIFT		40
>>  #define ARCH_PEBS_LBR			(0x3ull << ARCH_PEBS_LBR_SHIFT)
>>  #define ARCH_PEBS_VECR_XMM		BIT_ULL(49)
>> +#define ARCH_PEBS_VECR_YMMH		BIT_ULL(50)
> [Severity: Low]
> Will this trigger a Kernel ABI header differences warning during the perf build?
>
> If the corresponding kernel-side macros are not already present in the
> arch/x86/include/asm/msr-index.h header of the tree this patch is applied
> against, check-headers.sh will flag a synchronization divergence. 
>
> Are these macros being merged in a separate patch series that needs to be
> applied first, or did the kernel counterpart miss getting included in this
> series?

The kernel header update is in a separate patchset which the cover letter
has mentioned.


>
>> +#define ARCH_PEBS_VECR_EGPRS		BIT_ULL(51)
>> +#define ARCH_PEBS_VECR_OPMASK		BIT_ULL(53)
> [ ... ]
>

  reply	other threads:[~2026-07-08  2:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06  2:34 [Patch v9 00/10] Perf tools: Support eGPRs/SSP/SIMD registers sampling Dapeng Mi
2026-07-06  2:34 ` [Patch v9 01/10] perf dwarf-regs: Fix DWARF register index bounds check Dapeng Mi
2026-07-06  2:34 ` [Patch v9 02/10] perf util: Add missed fields in _attr__fprintf() and __attr_swap() Dapeng Mi
2026-07-06  2:34 ` [Patch v9 03/10] tools headers: Sync x86 headers with kernel sources Dapeng Mi
2026-07-06  2:54   ` sashiko-bot
2026-07-08  2:05     ` Mi, Dapeng [this message]
2026-07-06  2:34 ` [Patch v9 04/10] perf headers: Sync perf_event.h/perf_regs.h with the kernel headers Dapeng Mi
2026-07-06  2:34 ` [Patch v9 05/10] perf regs: Support x86 eGPRs/SSP sampling Dapeng Mi
2026-07-06  2:59   ` sashiko-bot
2026-07-08  2:15     ` Mi, Dapeng
2026-07-06  2:34 ` [Patch v9 06/10] perf regs: Support x86 SIMD registers sampling Dapeng Mi
2026-07-06  2:34 ` [Patch v9 07/10] perf regs: Enable dumping of SIMD registers Dapeng Mi
2026-07-06  2:55   ` sashiko-bot
2026-07-08  2:21     ` Mi, Dapeng
2026-07-06  2:34 ` [Patch v9 08/10] perf dwarf-regs: Add SIMD/eGPRs support for x86 DWARF registers Dapeng Mi
2026-07-06  2:34 ` [Patch v9 09/10] perf tests: Add x86 eGPRs/SSP registers sampling test Dapeng Mi
2026-07-06  3:00   ` sashiko-bot
2026-07-08  2:30     ` Mi, Dapeng
2026-07-06  2:34 ` [Patch v9 10/10] perf tests: Add SIMD " Dapeng Mi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83893ff1-cc40-45dd-a14f-4ce6f66bcc4b@linux.intel.com \
    --to=dapeng1.mi@linux.intel.com \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox