Re: [PATCH 29/29] perf test: Add truncated perf.data robustness test

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Tue, May 26, 2026 at 10:19:40PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The cleanup routine may delete a file named '.old' in the current working directory if temporary file creation fails.
> --
> 
> commit 6d5a7740cf583f089ba666236f38032085207496
> Author: Arnaldo Carvalho de Melo <acme@redhat.com>
> 
> perf test: Add truncated perf.data robustness test
> 
> This commit adds a shell test to verify that perf report gracefully handles
> truncated perf.data files. It records a simple workload, truncates the file
> at various offsets, and checks that perf report exits cleanly with an error
> rather than crashing.
> 
> > diff --git a/tools/perf/tests/shell/data_validation.sh b/tools/perf/tests/shell/data_validation.sh
> > new file mode 100755
> > index 0000000000000..5c3e6fced6fce
> > --- /dev/null
> > +++ b/tools/perf/tests/shell/data_validation.sh
> > @@ -0,0 +1,85 @@
> [ ... ]
> > +err=0
> > +
> > +cleanup() {
> > +	rm -f "${perfdata}" "${perfdata}.old" "${truncated}" "${stderrfile}"
> > +	trap - EXIT TERM INT
> > +}
> > +trap 'cleanup; exit 1' TERM INT
> > +trap cleanup EXIT
> > +
> > +perfdata=$(mktemp /tmp/__perf_test.perf.data.XXXXX) || exit 2
> 
> [Severity: Medium]
> If mktemp fails (for example, if /tmp is out of space), the perfdata
> variable will be empty and the script will exit, triggering the EXIT trap.
> 
> Will the cleanup function then expand the command to rm -f "" ".old" and
> silently delete a file named .old in the current working directory?

Good catch, added the following patch to it:

   err=0
 
   cleanup() {
  -  rm -f "${perfdata}" "${perfdata}.old" "${truncated}" "${stderrfile}"
  +  [ -n "${perfdata}" ] && rm -f "${perfdata}" "${perfdata}.old"
  +  rm -f "${truncated}" "${stderrfile}"
     trap - EXIT TERM INT
   }
   trap 'cleanup; exit 1' TERM INT