Linux Perf Users
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Kohei Enju <kohei@enjuk.jp>
Cc: linux-perf-users@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>
Subject: Re: [PATCH v1 0/2] perf annotate: Fix source option behavior and
Date: Mon, 24 Aug 2026 15:12:19 -0700	[thread overview]
Message-ID: <aozBwyQ85OjoPlMi@google.com> (raw)
In-Reply-To: <20260818144149.101248-1-kohei@enjuk.jp>

Hello,

On Tue, Aug 18, 2026 at 02:40:11PM +0000, Kohei Enju wrote:
> Source annotation has been disabled by default since e201757f7a0a ("perf
> annotate: Fix source code annotate with objdump"), but the documentation
> still describes the old default. Also, an explicit --source does not
> currently override annotate.hide_src_code.
> 
> Update the documentation and make explicit --source/--no-source take
> precedence over the configuration.
> 
> Kohei Enju (2):
>   perf config: Fix annotate.hide_src_code documentation
>   perf annotate: Honor explicit --source option

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung

> 
>  tools/perf/Documentation/perf-annotate.txt  | 4 ++--
>  tools/perf/Documentation/perf-config.txt    | 6 +++---
>  tools/perf/Documentation/perf-report.txt    | 4 ++--
>  tools/perf/Documentation/perf-top.txt       | 4 ++--
>  tools/perf/Documentation/perfconfig.example | 2 +-
>  tools/perf/builtin-annotate.c               | 7 +++++--
>  tools/perf/builtin-report.c                 | 7 +++++--
>  tools/perf/builtin-top.c                    | 7 +++++--
>  8 files changed, 25 insertions(+), 16 deletions(-)
> 
> -- 
> 2.53.0
> 

  parent reply	other threads:[~2026-08-24 22:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 14:40 [PATCH v1 0/2] perf annotate: Fix source option behavior and Kohei Enju
2026-08-18 14:40 ` [PATCH v1 1/2] perf config: Fix annotate.hide_src_code documentation Kohei Enju
2026-08-18 16:05   ` sashiko-bot
2026-08-18 14:40 ` [PATCH v1 2/2] perf annotate: Honor explicit --source option Kohei Enju
2026-08-18 16:10   ` sashiko-bot
2026-08-24 22:12 ` Namhyung Kim [this message]
2026-09-08 21:52   ` [PATCH v1 0/2] perf annotate: Fix source option behavior and Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aozBwyQ85OjoPlMi@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=kohei@enjuk.jp \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox