Re: [PATCH v1 0/2] perf annotate: Fix source option behavior and

[Arnaldo Carvalho de Melo <acme@kernel.org>]

On Mon, Aug 24, 2026 at 03:12:19PM -0700, Namhyung Kim wrote:
> Hello,
> 
> On Tue, Aug 18, 2026 at 02:40:11PM +0000, Kohei Enju wrote:
> > Source annotation has been disabled by default since e201757f7a0a ("perf
> > annotate: Fix source code annotate with objdump"), but the documentation
> > still describes the old default. Also, an explicit --source does not
> > currently override annotate.hide_src_code.
> > 
> > Update the documentation and make explicit --source/--no-source take
> > precedence over the configuration.
> > 
> > Kohei Enju (2):
> >   perf config: Fix annotate.hide_src_code documentation
> >   perf annotate: Honor explicit --source option
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Please rebase, I'll push the patches I have locally later today after
the usual build tests on many distro containers:

⬢ [acme@toolbx perf-tools-next]$        git am ./20260818_kohei_perf_annotate_fix_source_option_behavior_and.mbx
Applying: perf config: Fix annotate.hide_src_code documentation
Applying: perf annotate: Honor explicit --source option
error: patch failed: tools/perf/builtin-top.c:1851
error: tools/perf/builtin-top.c: patch does not apply
Patch failed at 0002 perf annotate: Honor explicit --source option
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
⬢ [acme@toolbx perf-tools-next]$