Re: [RFC PATCH v7 06/28] KVM: arm64: Add KVM_CAP_ARM_SPE capability

[Alexandru Elisei <alexandru.elisei@arm.com>]

Hi Lorenzo,

On Thu, Nov 12, 2026 at 03:34:15PM +0000, Alexandru Elisei wrote:
> Hi Lorenzo,
> 
> On Thu, Oct 15, 2026 at 05:51:03PM +0100, Lorenzo Stoakes (ARM) wrote:
> > On Thu, Sep 03, 2026 at 05:06:01PM +0100, Alexandru Elisei wrote:
> > > [..]
> > > +	if (!entry)
> > > +		return;
> > 
> > Hmm, shouldn't failing to allocate here be an error, or at least a warning?
> 
> I don't think it's something that should cause the probe to fail. I could
> add a warning, I guess, to let the user know why KVM_CAP_ARM_SPE is missing
> even though the SPE module was loaded successfully.

On second thought, there's really no need to taint the kernel if the
allocation fails, KVM and the SPE driver can still function correctly.
Since the likelyhood of it happening is very low (it's a small allocation,
only three pointers), and userspace can detect it happening because
KVM_CAP_ARM_SPE is not available, I am inclined to keep it as it is and not
print a warning.

Thanks,
Alex