Re: [PATCH v3 4/6] dt-bindings: usb: ti,am335x-usb-ctrl-module: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Documentation loss for `reg` property entries during dt-schema conversion.
--

commit c1a1061abb654fbffdeb37f5a8ae9d8c5c5596f0
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: usb: ti,am335x-usb-ctrl-module: Convert to DT schema

Convert the TI AM335x USB Control Module text bindings to DT schema. No
functional changes.

> diff --git a/Documentation/devicetree/bindings/usb/am33xx-usb.txt b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
> index 5973f88bcc65d..94312ad8ec8cd 100644
> --- a/Documentation/devicetree/bindings/usb/am33xx-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/am33xx-usb.txt
> @@ -8,15 +8,6 @@ The glue layer contains multiple child nodes. It is required to have
>  at least a control module node, USB node and a PHY node. The second USB
>  node and its PHY node are optional. The DMA node is also optional.
>  
> -Reset module
> -~~~~~~~~~~~~
> -- compatible: ti,am335x-usb-ctrl-module
> -- reg: offset and length of the "USB control registers" in the "Control
> -  Module" block. A second offset and length for the USB wake up control
> -  in the same memory block.
> -- reg-names: "phy_ctrl" for the "USB control registers" and "wakeup" for
> -  the USB wake up control register.
> -

[ ... ]

> diff --git a/Documentation/devicetree/bindings/usb/ti,am335x-usb-ctrl-module.yaml b/Documentation/devicetree/bindings/usb/ti,am335x-usb-ctrl-module.yaml
> new file mode 100644
> index 0000000000000..f8ac0af745c6c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,am335x-usb-ctrl-module.yaml
> @@ -0,0 +1,38 @@

[ ... ]

> +properties:
> +  compatible:
> +    const: ti,am335x-usb-ctrl-module
> +
> +  reg:
> +    maxItems: 2

[Severity: Low]
Does this YAML conversion lose some of the documentation details from the
original text binding?

The previous text binding included explicit descriptions for the two reg
entries ("USB control registers" and "USB wake up control"). While reg-names
are provided below, should an items list under reg be included to preserve
these explicit descriptions?

> +
> +  reg-names:
> +    items:
> +      - const: phy_ctrl
> +      - const: wakeup

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-ti-am33-usb-v3-0-5e15c617d2e9@gmail.com?part=4

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy