Re: [PATCH v3 3/6] dt-bindings: usb: ti,musb-am33xx: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing type definition for vendor property `mentor,ram-bits`.
--

commit b18161dcce0d8d9c92432e06f2d6b68cc0d0e262
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: usb: ti,musb-am33xx: Convert to DT schema

This commit converts the TI AM33xx MUSB text bindings to DT schema. It also
allows an optional vbus interrupt and adds interface-type and phy-names
properties for dm816x hardware.

> diff --git a/Documentation/devicetree/bindings/usb/ti,musb-am33xx.yaml b/Documentation/devicetree/bindings/usb/ti,musb-am33xx.yaml
> new file mode 100644
> index 0000000000000..cc01edc75d11e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,musb-am33xx.yaml

[ ... ]

> +  mentor,num-eps:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Specifies the number of endpoints.
> +    const: 16
> +
> +  mentor,ram-bits:
> +    description: Specifies the ram address size.
> +    const: 12

[Severity: Low]
Is mentor,ram-bits missing a type definition?

Without a type reference for a custom property, make dt_binding_check issues
a 'missing type definition' warning and fails constraint evaluation against
valid DTS usage. DT schema parses cell arrays like <12> as matrices like
[[12]] if not told they are scalar integers, failing the const: 12 check.

Does this need a type reference like
$ref: /schemas/types.yaml#/definitions/uint32 similar to mentor,num-eps and
mentor,power?

> +
> +  mentor,power:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Controller supply capacity (in mA) when operating in host mode.
> +    const: 500

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-ti-am33-usb-v3-0-5e15c617d2e9@gmail.com?part=3

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy