Re: [PATCH v3 5/6] dt-bindings: usb: ti,am33xx-usb: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Undefined labels in the YAML example cause `dtc` compilation to fail during `make dt_binding_check`.
--

commit 8b02af2c630db204aabbcbc1828484db912830c0
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: usb: ti,am33xx-usb: Convert to DT schema

This commit converts the TI AM33xx USB Wrapper text binding to DT schema.
It drops the USB control module from child nodes, allows standard phy child
node names, and marks the legacy ti,hwmods property as deprecated.

> diff --git a/Documentation/devicetree/bindings/usb/ti,am33xx-usb.yaml b/Documentation/devicetree/bindings/usb/ti,am33xx-usb.yaml
> new file mode 100644
> index 0000000000000..0b36b9ddfb4a9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/ti,am33xx-usb.yaml

[ ... ]

> +examples:
> +  - |
> +    usb@47400000 {
> +        compatible = "ti,am33xx-usb";
> +        reg = <0x47400000 0x1000>;
> +        ranges;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ti,hwmods = "usb_otg_hs";
> +
> +        usb-phy@47401300 {
> +            compatible = "ti,am335x-usb-phy";
> +            reg = <0x47401300 0x100>;
> +            reg-names = "phy";
> +            ti,ctrl_mod = <&ctrl_mod>;

[Severity: Low]
Does this reference to ctrl_mod cause a build failure during dtc compilation?
The control module node and its label appear to have been removed from the
example during the text-to-YAML conversion, which may result in a fatal
"Reference to non-existent node or label" error when running make
dt_binding_check.

> +            #phy-cells = <0>;
> +        };
> +
> +        usb@47401000 {
> +            compatible = "ti,musb-am33xx";
> +            reg = <0x47401400 0x400>,
> +                  <0x47401000 0x200>;
> +            reg-names = "mc", "control";
> +            interrupts = <18>;
> +            interrupt-names = "mc";
> +            dr_mode = "otg";
> +            mentor,multipoint = <1>;
> +            mentor,num-eps = <16>;
> +            mentor,ram-bits = <12>;
> +            mentor,power = <500>;
> +            phys = <&usb0_phy>;

[Severity: Low]
Will dtc compilation fail on this phandle reference? The usb0_phy label
was removed from the usb-phy@47401300 node in the example above, meaning
this reference is undefined and may break make dt_binding_check.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260901-ti-am33-usb-v3-0-5e15c617d2e9@gmail.com?part=5

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy