From: sashiko-bot@kernel.org
To: "Krishna Chaitanya Chundru" <krishna.chundru@oss.qualcomm.com>
Cc: vkoul@kernel.org, devicetree@vger.kernel.org, robh@kernel.org,
olteanv@gmail.com, conor+dt@kernel.org,
linux-phy@lists.infradead.org, linux-pci@vger.kernel.org,
neil.armstrong@linaro.org
Subject: Re: [PATCH v4 3/6] PCI: qcom: Add Nord PCIe controller support
Date: Mon, 21 Sep 2026 05:46:05 +0000 [thread overview]
Message-ID: <20260921054605.7A8631F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260921-nord-v4-3-ed05c6e09240@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] pci: qcom: missing kernel-doc for disable_cgc in struct qcom_pcie_cfg
--
commit e586f6bf039bd0cdbc21480739c4165ddb038509
Author: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
PCI: qcom: Add Nord PCIe controller support
Add the Nord PCIe controller configuration and the platform-specific settings
required for correct operation. Includes a clock-gating workaround and disables
L0s, as documented in a private erratum.
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index b58a607b713f5..304628b57f33b 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -281,6 +281,7 @@ struct qcom_pcie_cfg {
> bool override_no_snoop;
> bool firmware_managed;
> bool no_l0s;
> + bool disable_cgc;
> };
[Severity: Low]
Should this new field be documented in the accompanying kernel-doc block?
The struct qcom_pcie_cfg has a kernel-doc comment block that explicitly
documents its members. The new disable_cgc field was not added to the
kernel-doc block, which leaves the struct documentation incomplete and will
trigger kernel-doc script warnings.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260921-nord-v4-0-ed05c6e09240@oss.qualcomm.com?part=3
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-09-21 5:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 5:37 [PATCH v4 0/6] Add PCIe support for Qualcomm Nord platform Krishna Chaitanya Chundru
2026-09-21 5:37 ` [PATCH v4 1/6] dt-bindings: phy: qcom: add Nord QMP PCIe PHY binding Krishna Chaitanya Chundru
2026-09-21 5:43 ` sashiko-bot
2026-09-24 13:22 ` Krzysztof Kozlowski
2026-09-25 4:08 ` Krishna Chaitanya Chundru
2026-09-25 6:28 ` Krzysztof Kozlowski
2026-09-25 6:36 ` Krzysztof Kozlowski
2026-09-21 5:37 ` [PATCH v4 2/6] dt-bindings: pci: qcom: add Nord PCIe controller compatible Krishna Chaitanya Chundru
2026-09-21 5:42 ` sashiko-bot
2026-09-21 5:37 ` [PATCH v4 3/6] PCI: qcom: Add Nord PCIe controller support Krishna Chaitanya Chundru
2026-09-21 5:46 ` sashiko-bot [this message]
2026-09-21 5:37 ` [PATCH v4 4/6] phy: qcom: qmp: Move qphy_setbits/clrbits/checkbits to common header Krishna Chaitanya Chundru
2026-09-21 5:42 ` sashiko-bot
2026-09-21 5:37 ` [PATCH v4 5/6] phy: qcom: qmp-pcie: Refactor common multiphy handling Krishna Chaitanya Chundru
2026-09-21 5:48 ` sashiko-bot
2026-09-22 8:12 ` Shawn Guo
2026-09-25 15:23 ` Manivannan Sadhasivam
2026-09-21 5:37 ` [PATCH v4 6/6] phy: qcom: qmp-pcie: Add Nord Gen5x16 PCIe multi-PHY support Krishna Chaitanya Chundru
2026-09-21 5:58 ` sashiko-bot
2026-09-22 8:12 ` Shawn Guo
2026-09-25 15:25 ` Manivannan Sadhasivam
2026-09-21 6:30 ` [PATCH v4 0/6] Add PCIe support for Qualcomm Nord platform Qiang Yu
2026-09-21 7:37 ` Konrad Dybcio
2026-09-22 9:18 ` Qiang Yu
2026-09-22 8:13 ` Shawn Guo
2026-10-03 9:36 ` (subset) " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260921054605.7A8631F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krishna.chundru@oss.qualcomm.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=olteanv@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox