From: Vladimir Zapolskiy <vz@kernel.org>
To: Loic Poulain <loic.poulain@oss.qualcomm.com>,
Vladimir Zapolskiy <vz@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
Bryan O'Donoghue <bod@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-msm@vger.kernel.org,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
linux-phy@lists.infradead.org, Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/7] arm64: dts: qcom: sm8450: Add CAMSS device tree node
Date: Tue, 27 Oct 2026 00:38:57 +0200 [thread overview]
Message-ID: <378094fb-5f7f-42c6-a91f-158e2083a6cb@kernel.org> (raw)
In-Reply-To: <CAFEp6-03Kqxya74Cd+hgueZ0D4xAcYNOx_R1sNqdMu2JrMBynw@mail.gmail.com>
Hi Loic.
On 10/26/26 18:32, Loic Poulain wrote:
> On Fri, Oct 23, 2026 at 6:31 PM Vladimir Zapolskiy <vz@kernel.org> wrote:
>>
>> Add Qualcomm Waipio CAMSS device tree node to the platform dtsi file,
>> the CAMSS input ports are connected to output ports of CSIPHY devices.
>>
>> Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm8450.dtsi | 167 +++++++++++++++++++++++++++
>> 1 file changed, 167 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> index babf1a4196a1..7f5b0501a23e 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
>> @@ -3310,6 +3310,167 @@ cci1_i2c1: i2c-bus@1 {
>> };
>> };
>>
>> + camss: isp@acb6000 {
>> + compatible = "qcom,waipio-camss";
>> + reg = <0 0xacb6000 0 0x1000>,
>> + <0 0xacb7000 0 0x1000>,
>> + <0 0xacb9000 0 0x1000>,
>> + <0 0xacbb000 0 0x1000>,
>> + <0 0xacc6000 0 0x1000>,
>> + <0 0xacca000 0 0x1000>,
>> + <0 0xacf6000 0 0x1000>,
>> + <0 0xacf7000 0 0x1000>,
>> + <0 0xacf8000 0 0x1000>,
>> + <0 0xac62000 0 0x3000>,
>> + <0 0xac71000 0 0x3000>,
>> + <0 0xac80000 0 0x3000>,
>> + <0 0xacc7000 0 0x2000>,
>> + <0 0xaccb000 0 0x2000>;
>> + reg-names = "csid_wrapper",
>> + "csid0",
>> + "csid1",
>> + "csid2",
>> + "csid_lite0",
>> + "csid_lite1",
>> + "tpg0",
>> + "tpg1",
>> + "tpg2",
>> + "vfe0",
>> + "vfe1",
>> + "vfe2",
>> + "vfe_lite0",
>> + "vfe_lite1";
>
> Is there a camss "top" register to describe here? e.g. to retrieve the
> CAMSS hardware version.
I'm not aware of anything like that. What is "CAMSS hardware version"?
CAMSS embraces various blocks, there are CSID and VFE, full and lite
IPs, and all these components do export their versions individually.
>> + clocks = <&camcc CAM_CC_CAMNOC_AXI_CLK>,
>> + <&camcc CAM_CC_CORE_AHB_CLK>,
>> + <&camcc CAM_CC_CPAS_AHB_CLK>,
>> + <&camcc CAM_CC_CPAS_FAST_AHB_CLK>,
>> + <&camcc CAM_CC_CPAS_IFE_0_CLK>,
>> + <&camcc CAM_CC_CPAS_IFE_1_CLK>,
>> + <&camcc CAM_CC_CPAS_IFE_2_CLK>,
>> + <&camcc CAM_CC_CPAS_IFE_LITE_CLK>,
>> + <&camcc CAM_CC_CSID_CLK>,
>> + <&camcc CAM_CC_CSID_CSIPHY_RX_CLK>,
>> + <&gcc GCC_CAMERA_HF_AXI_CLK>,
>> + <&camcc CAM_CC_IFE_0_CLK>,
>> + <&camcc CAM_CC_IFE_0_FAST_AHB_CLK>,
>> + <&camcc CAM_CC_IFE_1_CLK>,
>> + <&camcc CAM_CC_IFE_1_FAST_AHB_CLK>,
>> + <&camcc CAM_CC_IFE_2_CLK>,
>> + <&camcc CAM_CC_IFE_2_FAST_AHB_CLK>,
>> + <&camcc CAM_CC_IFE_LITE_CLK>,
>> + <&camcc CAM_CC_IFE_LITE_AHB_CLK>,
>> + <&camcc CAM_CC_IFE_LITE_CPHY_RX_CLK>,
>> + <&camcc CAM_CC_IFE_LITE_CSID_CLK>;
>> + clock-names = "camnoc_axi",
>> + "core_ahb",
>> + "cpas_ahb",
>> + "cpas_fast_ahb",
>> + "cpas_vfe0",
>> + "cpas_vfe1",
>> + "cpas_vfe2",
>> + "cpas_vfe_lite",
>> + "csid",
>> + "csiphy_rx",
>> + "gcc_hf_axi",
>> + "vfe0",
>> + "vfe0_fast_ahb",
>> + "vfe1",
>> + "vfe1_fast_ahb",
>> + "vfe2",
>> + "vfe2_fast_ahb",
>> + "vfe_lite",
>> + "vfe_lite_ahb",
>> + "vfe_lite_cphy_rx",
>> + "vfe_lite_csid";
>> + interrupts = <GIC_SPI 464 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 466 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 640 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 641 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>,
>> + <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>;
>> + interrupt-names = "csid0",
>> + "csid1",
>> + "csid2",
>> + "csid_lite0",
>> + "csid_lite1",
>> + "vfe0",
>> + "vfe1",
>> + "vfe2",
>> + "vfe_lite0",
>> + "vfe_lite1";
>> + interconnects = <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_CAMERA_CFG 0>,
>> + <&mmss_noc MASTER_CAMNOC_HF 0 &mc_virt SLAVE_EBI1 0>;
>> + interconnect-names = "ahb",
>> + "hf_mnoc";
>> + iommus = <&apps_smmu 0x800 0x460>;
>> + power-domains = <&camcc IFE_0_GDSC>,
>> + <&camcc IFE_1_GDSC>,
>> + <&camcc IFE_2_GDSC>,
>> + <&camcc TITAN_TOP_GDSC>;
>> + power-domain-names = "ife0",
>> + "ife1",
>> + "ife2",
>> + "top";
>> + status = "disabled";
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> +
>> + camss_csiphy0_inep: endpoint {
>> + remote-endpoint = <&csiphy0_out_ep>;
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> +
>> + camss_csiphy1_inep: endpoint {
>> + remote-endpoint = <&csiphy1_out_ep>;
>> + };
>> + };
>> +
>> + port@2 {
>> + reg = <2>;
>> +
>> + camss_csiphy2_inep: endpoint {
>> + remote-endpoint = <&csiphy2_out_ep>;
>> + };
>> + };
>> +
>> + port@3 {
>> + reg = <3>;
>> +
>> + camss_csiphy3_inep: endpoint {
>> + remote-endpoint = <&csiphy3_out_ep>;
>> + };
>> + };
>> +
>> + port@4 {
>> + reg = <4>;
>> +
>> + camss_csiphy4_inep: endpoint {
>> + remote-endpoint = <&csiphy4_out_ep>;
>> + };
>> + };
>> +
>> + port@5 {
>> + reg = <5>;
>> +
>> + camss_csiphy5_inep: endpoint {
>> + remote-endpoint = <&csiphy5_out_ep>;
>> + };
>> + };
>> + };
>> + };
>> +
>> csiphy0: phy@ace4000 {
>> compatible = "qcom,waipio-csi2-phy", "qcom,x1e80100-csi2-phy";
>> reg = <0 0x0ace4000 0 0x2000>;
>> @@ -3349,6 +3510,7 @@ port@1 {
>> reg = <1>;
>>
>> csiphy0_out_ep: endpoint {
>> + remote-endpoint = <&camss_csiphy0_inep>;
>> };
>> };
>> };
>> @@ -3393,6 +3555,7 @@ port@1 {
>> reg = <1>;
>>
>> csiphy1_out_ep: endpoint {
>> + remote-endpoint = <&camss_csiphy1_inep>;
>> };
>> };
>> };
>> @@ -3437,6 +3600,7 @@ port@1 {
>> reg = <1>;
>>
>> csiphy2_out_ep: endpoint {
>> + remote-endpoint = <&camss_csiphy2_inep>;
>> };
>> };
>> };
>> @@ -3481,6 +3645,7 @@ port@1 {
>> reg = <1>;
>>
>> csiphy3_out_ep: endpoint {
>> + remote-endpoint = <&camss_csiphy3_inep>;
>> };
>> };
>> };
>> @@ -3525,6 +3690,7 @@ port@1 {
>> reg = <1>;
>>
>> csiphy4_out_ep: endpoint {
>> + remote-endpoint = <&camss_csiphy4_inep>;
>> };
>> };
>> };
>> @@ -3569,6 +3735,7 @@ port@1 {
>> reg = <1>;
>>
>> csiphy5_out_ep: endpoint {
>> + remote-endpoint = <&camss_csiphy5_inep>;
>> };
>> };
>> };
>> --
>> 2.53.0
>>
--
Best wishes,
Vladimir
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2026-10-26 22:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 16:30 [PATCH 0/7] media: qcom: camss: Add Waipio CAMSS support Vladimir Zapolskiy
2026-10-23 16:30 ` [PATCH 1/7] dt-bindings: phy: qcom,x1e80100-csi2-phy: Add Waipio compatible Vladimir Zapolskiy
2026-10-23 16:44 ` sashiko-bot
2026-10-23 22:43 ` Bryan O'Donoghue
2026-10-26 10:04 ` Krzysztof Kozlowski
2026-10-23 16:30 ` [PATCH 2/7] arm64: dts: qcom: sm8450: Add CSI2 PHY device tree nodes Vladimir Zapolskiy
2026-10-23 16:57 ` sashiko-bot
2026-10-23 22:44 ` Bryan O'Donoghue
2026-10-26 10:05 ` Krzysztof Kozlowski
2026-10-23 16:30 ` [PATCH 3/7] dt-bindings: media: Add description of Qualcomm Waipio CAMSS IP Vladimir Zapolskiy
2026-10-23 16:58 ` sashiko-bot
2026-10-26 10:03 ` Krzysztof Kozlowski
2026-10-23 16:30 ` [PATCH 4/7] arm64: dts: qcom: sm8450: Add CAMSS device tree node Vladimir Zapolskiy
2026-10-26 10:04 ` Krzysztof Kozlowski
2026-10-26 16:32 ` Loic Poulain
2026-10-26 22:38 ` Vladimir Zapolskiy [this message]
2026-10-27 9:07 ` Loic Poulain
2026-10-27 9:54 ` Vladimir Zapolskiy
2026-10-27 10:31 ` Loic Poulain
2026-10-27 12:57 ` Vladimir Zapolskiy
2026-10-27 11:14 ` Konrad Dybcio
2026-10-23 16:30 ` [PATCH 5/7] arm64: dts: qcom: sm8450: Add description of pins with MCLK function Vladimir Zapolskiy
2026-10-26 14:09 ` Konrad Dybcio
2026-10-23 16:30 ` [PATCH 6/7] media: qcom: camss: Allow CSI2 PHY devices without CSIPHY resources Vladimir Zapolskiy
2026-10-23 16:30 ` [PATCH 7/7] media: qcom: camss: Add Waipio CAMSS support Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=378094fb-5f7f-42c6-a91f-158e2083a6cb@kernel.org \
--to=vz@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mani@kernel.org \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox