Re: [PATCH 1/7] dt-bindings: phy: qcom,x1e80100-csi2-phy: Add Waipio compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: phy: qcom,x1e80100-csi2-phy: use sm8450 instead of waipio
--

commit 9073ae477c0f915b568e424d2c24c3320e9b118f
Author: Vladimir Zapolskiy <vz@kernel.org>

dt-bindings: phy: qcom,x1e80100-csi2-phy: Add Waipio compatible

This patch adds the qcom,waipio-csi2-phy compatible string to the
qcom,x1e80100-csi2-phy Devicetree binding schema.

> diff --git a/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml
> index 1f1e2a4993b2a..2a11ca7c7d112 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml
> @@ -19,7 +19,9 @@ properties:
>      oneOf:
>        - const: qcom,x1e80100-csi2-phy
>        - items:
> -          - const: qcom,glymur-csi2-phy
> +          - enum:
> +              - qcom,glymur-csi2-phy
> +              - qcom,waipio-csi2-phy

[Severity: Low]
Should this compatible string be qcom,sm8450-csi2-phy instead of
qcom,waipio-csi2-phy?

Waipio is the internal codename for the Snapdragon 8 Gen 1 (SM8450) SoC, much
like Hamoa is the codename for X1E80100. In upstream Devicetree bindings,
this platform is established under qcom,sm8450:

Documentation/devicetree/bindings/arm/qcom.yaml:
      - items:
          - enum:
              - qcom,sm8450-hdk
              - qcom,sm8450-qrd
              - samsung,r0q
              - sony,pdx223
              - sony,pdx224
          - const: qcom,sm8450

Documentation/devicetree/bindings/arm/qcom-soc.yaml also defines the allowed
naming patterns for SoC IP block compatibles and does not include waipio in
the list of permitted codename prefixes:

        # Preferred naming style for compatibles of SoC components:
        - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$"
        - pattern: "^qcom,sar[0-9]+[a-z]?-.*$"
        - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
        - pattern: "^qcom,(eliza|kaanapali|glymur|hawi|mahua|maili|milos|nord|shikra)-.+$"

Other SM8450 camera and PHY bindings, such as qcom,sm8450-camcc in
Documentation/devicetree/bindings/clock/qcom,sm8450-camcc.yaml, use the
qcom,sm8450-* prefix.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023163057.775917-1-vz@kernel.org?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy