Re: [PATCH 3/7] dt-bindings: media: Add description of Qualcomm Waipio CAMSS IP

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: media: use of codename waipio instead of sm8450 in compatible
--

commit 301ac07bd476ba12e0b4279c2772097ff587606b
Author: Vladimir Zapolskiy <vz@kernel.org>

dt-bindings: media: Add description of Qualcomm Waipio CAMSS IP

This commit adds the Device Tree binding schema for the Qualcomm Waipio
(SM8450) Camera Subsystem (CAMSS) IP block.

> diff --git a/Documentation/devicetree/bindings/media/qcom,waipio-camss.yaml b/Documentation/devicetree/bindings/media/qcom,waipio-camss.yaml
> new file mode 100644
> index 0000000000000..3da1f3c0d6187
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,waipio-camss.yaml
> @@ -0,0 +1,274 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/qcom,waipio-camss.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Waipio Camera Subsystem (CAMSS)
> +
> +maintainers:
> +  - Vladimir Zapolskiy <vz@kernel.org>
> +
> +description:
> +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms.
> +
> +properties:
> +  compatible:
> +    const: qcom,waipio-camss

[Severity: Low]
Should this compatible string and schema filename use sm8450 instead of the
internal codename waipio (i.e. qcom,sm8450-camss), and similarly for
qcom,waipio-csi2-phy in
Documentation/devicetree/bindings/phy/qcom,x1e80100-csi2-phy.yaml?

In Documentation/devicetree/bindings/arm/qcom-soc.yaml, component compatibles
for Qualcomm SoCs follow the SoC model naming pattern:

    # Preferred naming style for compatibles of SoC components:
    - pattern: "^qcom,(apq|ipq|mdm|msm|qcm|qcs|q[dr]u|sa|sc|sd[amx]|sm|x1[ep])[0-9]+(pro)?-.*$"
    - pattern: "^qcom,sar[0-9]+[a-z]?-.*$"
    - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
    - pattern: "^qcom,(eliza|kaanapali|glymur|hawi|mahua|maili|milos|nord|shikra)-.+$"

Waipio is the internal codename for SM8450, which is upstreamed throughout the
tree under sm8450 (such as qcom,sm8450-camcc, qcom,sm8450-cci, and
qcom,sm8450-mdss, as well as the sm8450 headers included in the example of
this binding) and matches the other SM8xxx CAMSS bindings like
qcom,sm8250-camss.yaml and qcom,sm8550-camss.yaml.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261023163057.775917-1-vz@kernel.org?part=3

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy