Re: [PATCH 4/4] arm64: dts: qcom: ipq5424: Enable PCIe PHYs and controllers

From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
Cc: <bhelgaas@google.com>, <lpieralisi@kernel.org>, <kw@linux.com>,
	<manivannan.sadhasivam@linaro.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>, <vkoul@kernel.org>,
	<kishon@kernel.org>, <andersson@kernel.org>,
	<konradybcio@kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>,
	<quic_srichara@quicinc.com>
Subject: Re: [PATCH 4/4] arm64: dts: qcom: ipq5424: Enable PCIe PHYs and controllers
Date: Fri, 3 Jan 2025 12:22:51 +0530	[thread overview]
Message-ID: <Z3eJQyJXSBG+oFF4@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <20241213134950.234946-5-quic_mmanikan@quicinc.com>

On Fri, Dec 13, 2024 at 07:19:50PM +0530, Manikanta Mylavarapu wrote:

[ .  .  . ]

> +&pcie2_phy {
> +	status = "okay";
> +};
> +
> +&pcie2 {
> +	pinctrl-0 = <&pcie2_default_state>;
> +	pinctrl-names = "default";
> +
> +	perst-gpios = <&tlmm 31 GPIO_ACTIVE_LOW>;
> +	status = "okay";
> +};

pcie2 should come before pcie2_phy

> +
> +&pcie3_phy {
> +	status = "okay";
> +};
> +
> +&pcie3 {
> +	pinctrl-0 = <&pcie3_default_state>;
> +	pinctrl-names = "default";
> +
> +	perst-gpios = <&tlmm 34 GPIO_ACTIVE_LOW>;
> +	status = "okay";
> +};

same here.

-Varada

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy