* Re: [PATCH] phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750
2025-06-16 6:25 [PATCH] phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750 Krzysztof Kozlowski
@ 2025-06-16 7:30 ` neil.armstrong
2025-06-16 10:52 ` Dmitry Baryshkov
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: neil.armstrong @ 2025-06-16 7:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, Vinod Koul, Kishon Vijay Abraham I,
Dmitry Baryshkov, Melody Olvera, Wesley Cheng, linux-arm-msm,
linux-phy, linux-kernel
On 16/06/2025 08:25, Krzysztof Kozlowski wrote:
> Add missing DP PHY status and VCO clock configuration registers to fix
> configuring the VCO rate on SM8750. Without proper VCO rate setting, it
> works on after-reset half of rate which is not enough for DP over USB to
> work as seen on logs:
>
> [drm:msm_dp_ctrl_link_train_1_2] *ERROR* max v_level reached
> [drm:msm_dp_ctrl_link_train_1_2] *ERROR* link training #1 on phy 0 failed. ret=-11
>
> Fixes: c4364048baf4 ("phy: qcom: qmp-combo: Add new PHY sequences for SM8750")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> index 8b9710a9654a..f07d097b129f 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
> @@ -228,6 +228,9 @@ static const unsigned int qmp_v8_usb3phy_regs_layout[QPHY_LAYOUT_SIZE] = {
> [QPHY_COM_CMN_STATUS] = QSERDES_V8_COM_CMN_STATUS,
> [QPHY_COM_BIAS_EN_CLKBUFLR_EN] = QSERDES_V8_COM_BIAS_EN_CLKBUFLR_EN,
>
> + [QPHY_DP_PHY_STATUS] = QSERDES_V6_DP_PHY_STATUS,
> + [QPHY_DP_PHY_VCO_DIV] = QSERDES_V6_DP_PHY_VCO_DIV,
> +
> [QPHY_TX_TX_POL_INV] = QSERDES_V8_TX_TX_POL_INV,
> [QPHY_TX_TX_DRV_LVL] = QSERDES_V8_TX_TX_DRV_LVL,
> [QPHY_TX_TX_EMP_POST1_LVL] = QSERDES_V8_TX_TX_EMP_POST1_LVL,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750
2025-06-16 6:25 [PATCH] phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750 Krzysztof Kozlowski
2025-06-16 7:30 ` neil.armstrong
@ 2025-06-16 10:52 ` Dmitry Baryshkov
2025-06-16 17:00 ` Vinod Koul
2025-06-27 0:47 ` Vinod Koul
3 siblings, 0 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2025-06-16 10:52 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Vinod Koul, Kishon Vijay Abraham I, Melody Olvera, Wesley Cheng,
linux-arm-msm, linux-phy, linux-kernel
On Mon, Jun 16, 2025 at 08:25:42AM +0200, Krzysztof Kozlowski wrote:
> Add missing DP PHY status and VCO clock configuration registers to fix
> configuring the VCO rate on SM8750. Without proper VCO rate setting, it
> works on after-reset half of rate which is not enough for DP over USB to
> work as seen on logs:
>
> [drm:msm_dp_ctrl_link_train_1_2] *ERROR* max v_level reached
> [drm:msm_dp_ctrl_link_train_1_2] *ERROR* link training #1 on phy 0 failed. ret=-11
>
> Fixes: c4364048baf4 ("phy: qcom: qmp-combo: Add new PHY sequences for SM8750")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750
2025-06-16 6:25 [PATCH] phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750 Krzysztof Kozlowski
2025-06-16 7:30 ` neil.armstrong
2025-06-16 10:52 ` Dmitry Baryshkov
@ 2025-06-16 17:00 ` Vinod Koul
2025-06-17 6:00 ` Krzysztof Kozlowski
2025-06-27 0:47 ` Vinod Koul
3 siblings, 1 reply; 6+ messages in thread
From: Vinod Koul @ 2025-06-16 17:00 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kishon Vijay Abraham I, Dmitry Baryshkov, Melody Olvera,
Wesley Cheng, linux-arm-msm, linux-phy, linux-kernel
On 16-06-25, 08:25, Krzysztof Kozlowski wrote:
> Add missing DP PHY status and VCO clock configuration registers to fix
> configuring the VCO rate on SM8750. Without proper VCO rate setting, it
> works on after-reset half of rate which is not enough for DP over USB to
> work as seen on logs:
>
> [drm:msm_dp_ctrl_link_train_1_2] *ERROR* max v_level reached
> [drm:msm_dp_ctrl_link_train_1_2] *ERROR* link training #1 on phy 0 failed. ret=-11
Hey,
This does not apply for on phy/fixes
Can you please rebase
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750
2025-06-16 17:00 ` Vinod Koul
@ 2025-06-17 6:00 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-17 6:00 UTC (permalink / raw)
To: Vinod Koul
Cc: Kishon Vijay Abraham I, Dmitry Baryshkov, Melody Olvera,
Wesley Cheng, linux-arm-msm, linux-phy, linux-kernel
On 16/06/2025 19:00, Vinod Koul wrote:
> On 16-06-25, 08:25, Krzysztof Kozlowski wrote:
>> Add missing DP PHY status and VCO clock configuration registers to fix
>> configuring the VCO rate on SM8750. Without proper VCO rate setting, it
>> works on after-reset half of rate which is not enough for DP over USB to
>> work as seen on logs:
>>
>> [drm:msm_dp_ctrl_link_train_1_2] *ERROR* max v_level reached
>> [drm:msm_dp_ctrl_link_train_1_2] *ERROR* link training #1 on phy 0 failed. ret=-11
>
> Hey,
>
> This does not apply for on phy/fixes
>
> Can you please rebase
That's not a phy/fixes. It is a patch for next, as pointed out by fixed
commit.
Best regards,
Krzysztof
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750
2025-06-16 6:25 [PATCH] phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750 Krzysztof Kozlowski
` (2 preceding siblings ...)
2025-06-16 17:00 ` Vinod Koul
@ 2025-06-27 0:47 ` Vinod Koul
3 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2025-06-27 0:47 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Dmitry Baryshkov, Melody Olvera,
Wesley Cheng, linux-arm-msm, linux-phy, linux-kernel,
Krzysztof Kozlowski
On Mon, 16 Jun 2025 08:25:42 +0200, Krzysztof Kozlowski wrote:
> Add missing DP PHY status and VCO clock configuration registers to fix
> configuring the VCO rate on SM8750. Without proper VCO rate setting, it
> works on after-reset half of rate which is not enough for DP over USB to
> work as seen on logs:
>
> [drm:msm_dp_ctrl_link_train_1_2] *ERROR* max v_level reached
> [drm:msm_dp_ctrl_link_train_1_2] *ERROR* link training #1 on phy 0 failed. ret=-11
>
> [...]
Applied, thanks!
[1/1] phy: qcom: qmp-combo: Add missing PLL (VCO) configuration on SM8750
commit: 304c102cff7382353a28039907a7017bde795db9
Best regards,
--
~Vinod
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
^ permalink raw reply [flat|nested] 6+ messages in thread