Re: [PATCH RFC v2 1/4] phy: Add MIPI C-PHY mode and configuration options

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] phy: use of non-standard integer types in struct phy_configure_opts_mipi_cphy
--

commit d9667cf3e3ee5fb3d84322cb2fefa2dae78c9e33
Author: George Neacsu <geocausa@gmail.com>

phy: Add MIPI C-PHY mode and configuration options

This commit introduces PHY_MODE_MIPI_CPHY and a new structure, struct
phy_configure_opts_mipi_cphy, to the generic PHY framework. This allows
CSI-2 receivers to specify the symbol rate and number of trios for C-PHYs.

> diff --git a/include/linux/phy/phy-mipi-cphy.h b/include/linux/phy/phy-mipi-cphy.h
> new file mode 100644
> index 0000000000000..ef6af61ded254
> --- /dev/null
> +++ b/include/linux/phy/phy-mipi-cphy.h
> @@ -0,0 +1,27 @@
[ ... ]
> +struct phy_configure_opts_mipi_cphy {
> +	/**
> +	 * @symbol_rate:
> +	 *
> +	 * Symbol rate on each trio, in symbols per second.
> +	 */
> +	unsigned long long	symbol_rate;

[Severity: Low]
This isn't a bug, but would it be better to use explicitly-sized types like u64
here instead of unsigned long long?

> +
> +	/**
> +	 * @trios:
> +	 *
> +	 * Number of active trios.
> +	 */
> +	unsigned char		trios;

[Severity: Low]
Similarly, would it be better to use u8 here instead of unsigned char?

> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016-x1e-cphy-rfc-v2-0-377654253193@gmail.com?part=1

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy