Re: [RFC 4/6] Add cpumask to track throughput intensive tasks

[Dietmar Eggemann <dietmar.eggemann@arm.com>]

On 4/11/19 5:54 PM, Dietmar Eggemann wrote:
> On 3/22/19 7:06 AM, Parth Shah wrote:
>> WOF tasks indicates the workload optimized frequency tasks which has
> 
> You should explain what WOF stands for before you it. I think its only 
> done in the next patch.
> 
> [...]
> 
>> @@ -6225,10 +6232,11 @@ static const int core_cap_mf = 16;
>>    */
>>   static int select_non_idle_core(struct task_struct *p, int prev_cpu)
>>   {
>> -    struct cpumask *cpus = this_cpu_cpumask_var_ptr(select_idle_mask);
>> +    struct cpumask highutil_task_mask_copy;
> 
> Don't put struct cpumask on the stack.

Why don't you provide a per-cpu mask for highutil_task_cpu_mask and 
wof_tasks_cpu_mask like we have for select_idle_mask?

DEFINE_PER_CPU(cpumask_var_t, select_idle_mask);

[...]