Re: [RFC 5/6] Improvise cgroup interface for classifying jitter from WOF tasks

[Dietmar Eggemann <dietmar.eggemann@arm.com>]

On 4/12/19 5:48 PM, Parth Shah wrote:
> 
> 
> On 4/12/19 6:38 PM, Dietmar Eggemann wrote:
>> On 3/22/19 7:06 AM, Parth Shah wrote:

[...]

> Maybe the comment is not self-explainable. Please follow a below one,
> 
> Here we have two cpumask to iterate through
> 1. wof_tasks_cpu_mask which contains CPU occupied by user classified task and is hence easier to track
> 2. highutil_task_cpu_mask which contains CPU which are non-idle (not core_underutilized)
> 
> So, the selection of "cpus" can be either from the above two masks.
> Selecting "wof_tasks_cpu_mask" leads to quicker and better selection of non idle CPU,
> whereas "highutil_task_cpu_mask" will contain more CPUs (inclusive of wof_tasks_cpu_mask) and hence finding perfect CPU may require more iterations.
> 
> Hence, selecting "highutil_task_cpu_mask" is relatively exhaustive (which I termed "longer code path") in general cases.
> 
> Hope this helps.

Ah, OK, that helped to understand it.

[...]