From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Parth Shah <parth015@linux.vnet.ibm.com>, linux-pm@vger.kernel.org
Subject: Re: [RFC 6/6] Providing TurboSched as config option
Date: Wed, 10 Apr 2019 18:39:35 +0200 [thread overview]
Message-ID: <84e0894c-b38c-3e14-998f-71b23670baf2@arm.com> (raw)
In-Reply-To: <20190322060621.27021-7-parth015@linux.vnet.ibm.com>
On 3/22/19 7:06 AM, Parth Shah wrote:
> Signed-off-by: Parth Shah <parth015@linux.vnet.ibm.com>
[...]
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 06e440d3ea2f..2484fa8c49d0 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -54,6 +54,7 @@ unsigned int sysctl_sched_rt_period = 1000000;
>
> __read_mostly int scheduler_running;
>
> +#ifdef CONFIG_TURBO_SCHED
This one takes sysctl_sched_rt_runtime away from a non
CONFIG_TURBO_SCHED build like arm64 defconfig.
...
MODPOST vmlinux.o
kernel/sysctl.o:(.data+0x14d0): undefined reference to
`sysctl_sched_rt_runtime'
kernel/sched/core.o: In function `dl_bandwidth_enabled':
/opt/git/kernel_org/kernel/sched/sched.h:282: undefined reference to
`sysctl_sched_rt_runtime'
...
[...]
--- 8< ---
@@ -54,13 +54,13 @@ unsigned int sysctl_sched_rt_period = 1000000;
__read_mostly int scheduler_running;
-#ifdef CONFIG_TURBO_SCHED
/*
* part of the period that we allow rt tasks to run in us.
* default: 0.95s
*/
int sysctl_sched_rt_runtime = 950000;
+#ifdef CONFIG_TURBO_SCHED
next prev parent reply other threads:[~2019-04-10 16:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190322060621.27021-1-parth015@linux.vnet.ibm.com>
[not found] ` <20190322060621.27021-2-parth015@linux.vnet.ibm.com>
[not found] ` <0b198386-ef0b-75e0-e53a-1160c77326b7@arm.com>
2019-04-07 5:57 ` [RFC 1/6] Optimize wake-up task for Task Packing heuristic Parth Shah
2019-04-10 16:33 ` Dietmar Eggemann
2019-04-11 14:05 ` Dietmar Eggemann
2019-04-11 14:44 ` Parth Shah
[not found] ` <20190322060621.27021-4-parth015@linux.vnet.ibm.com>
[not found] ` <001101d4e35c$13951220$3abf3660$@net>
[not found] ` <20190404095854.GB25302@aks.ibm>
2019-04-07 6:43 ` [RFC 3/6] Introduce static key to enable or disable TurboSched Parth Shah
[not found] ` <20190322060621.27021-7-parth015@linux.vnet.ibm.com>
2019-04-10 16:39 ` Dietmar Eggemann [this message]
[not found] ` <20190322060621.27021-3-parth015@linux.vnet.ibm.com>
2019-04-11 13:46 ` [RFC 2/6] Provide cgroup interface for manual jitter classification Dietmar Eggemann
2019-04-15 7:23 ` Parth Shah
[not found] ` <20190322060621.27021-5-parth015@linux.vnet.ibm.com>
2019-04-11 15:54 ` [RFC 4/6] Add cpumask to track throughput intensive tasks Dietmar Eggemann
2019-04-12 10:47 ` Dietmar Eggemann
2019-04-12 11:16 ` Parth Shah
2019-04-12 10:58 ` Dietmar Eggemann
2019-04-12 11:31 ` Parth Shah
2019-04-12 11:13 ` Dietmar Eggemann
2019-04-12 11:23 ` Parth Shah
[not found] ` <20190322060621.27021-6-parth015@linux.vnet.ibm.com>
2019-04-11 16:01 ` [RFC 5/6] Improvise cgroup interface for classifying jitter from WOF tasks Dietmar Eggemann
2019-04-12 11:28 ` Parth Shah
2019-04-12 13:08 ` Dietmar Eggemann
2019-04-12 15:48 ` Parth Shah
2019-04-15 10:27 ` Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84e0894c-b38c-3e14-998f-71b23670baf2@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=linux-pm@vger.kernel.org \
--cc=parth015@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox