Re: [PATCH 2/2] power: supply: bq25890: Rename POWER_SUPPLY_PROP_CURRENT_NOW to CC current

[Marek Vasut <marex@denx.de>]

On 10/10/22 00:58, Michał Mirosław wrote:
> On Sun, Oct 09, 2022 at 09:18:39PM +0200, Marek Vasut wrote:
>> The POWER_SUPPLY_PROP_CURRENT_NOW property represents, as far as I can tell,
>> the immediate power supply input current, however, this driver reports the
>> immediate battery charge current using that property, i.e. content of REG12
>> ICHGR -- ADC conversion of Charge Current (IBAT). Replace the property with
>> POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT, which as far as I can tell should
>> be used to report immediate battery charge voltage.
>>
>> This also aligns the behavior of POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT
>> with POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE, as the former reports IBAT
>> and the later reports VBAT.
> 
> I believe this is wrong: CC_CURRENT would be the constant-current charge phase
> current limit (ICHG in REG04).
> 
> Documentation/power/power_supply_class.rst mentions that:
> 
> CONSTANT_CHARGE_CURRENT
>    constant charge current programmed by charger.

I think I will wait for the subsystem maintainer to clarify these 
properties, because right now, this driver seems to be a complete mess 
in terms of what it reports and through which property. And I'm afraid 
that is because neither of those properties are clearly documented.