Re: [PATCH 1/2] power: supply: bq25890: Add CC voltage to ADC properties

["Michał Mirosław" <mirq-linux@rere.qmqm.pl>]

On Sun, Oct 09, 2022 at 09:18:38PM +0200, Marek Vasut wrote:
> The POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE , representing register
> REG0E field BATV is an ADC conversion of Battery Voltage (VBAT). Mark
> the property as ADC one.

In this case I believe the property is representing wrong value: it
should be REG06 - the programmed voltage limit, and _MAX should reflect
maximum setting possible. Though I think there is no proper property
for the VSYS value that is currently occupying VOLTAGE_NOW - this
might be better modelled as a separate regulator maybe?

But, for the time being this look ok.

> Fixes: 21d90eda433f ("power: bq25890: fix ADC mode configuration")
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
> To: linux-pm@vger.kernel.org
> ---
>  drivers/power/supply/bq25890_charger.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
> index 6020b58c641d2..34dbd498f0f51 100644
> --- a/drivers/power/supply/bq25890_charger.c
> +++ b/drivers/power/supply/bq25890_charger.c
> @@ -432,6 +432,7 @@ static bool bq25890_is_adc_property(enum power_supply_property psp)
>  {
>  	switch (psp) {
>  	case POWER_SUPPLY_PROP_VOLTAGE_NOW:
> +	case POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE:
>  	case POWER_SUPPLY_PROP_CURRENT_NOW:
>  	case POWER_SUPPLY_PROP_TEMP:
>  		return true;
> -- 
> 2.35.1
> 

-- 
Michał Mirosław