From: Marek Vasut <marex@denx.de>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: linux-pm@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>
Subject: Re: [PATCH 1/2] power: supply: bq25890: Add CC voltage to ADC properties
Date: Mon, 10 Oct 2022 21:22:22 +0200 [thread overview]
Message-ID: <c528ae92-26bd-e6a9-a406-93a077d2fab7@denx.de> (raw)
In-Reply-To: <dde63fea-04eb-c438-27d3-fe6ff5c174bc@redhat.com>
On 10/10/22 15:50, Hans de Goede wrote:
> Hi,
Hi,
[...]
>> Though I think there is no proper property
>> for the VSYS value that is currently occupying VOLTAGE_NOW - this
>> might be better modelled as a separate regulator maybe?
>
> Ack, see above.
We already do have a regulator in the bq25890 driver. The regulator is
used as a switch to toggle OTG boost mode (supply from battery to VBUS),
but I don't see any users of this functionality, and I cannot imagine
how this would be modeled in DT. (Hans, can you clarify?)
There is the usb_work (usb_register_notifier()) which triggers workqueue
which does the same, toggles OTG boost mode, but this is only used in
case a valid USB PHY is found. I didn't find any users of this either.
Anyway, maybe we can extend the regulator to report VBus and register
another one to report VSys, where the VSys one can be plugged e.g. as
supply for PMIC in DT ?
[...]
next prev parent reply other threads:[~2022-10-10 19:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-09 19:18 [PATCH 1/2] power: supply: bq25890: Add CC voltage to ADC properties Marek Vasut
2022-10-09 19:18 ` [PATCH 2/2] power: supply: bq25890: Rename POWER_SUPPLY_PROP_CURRENT_NOW to CC current Marek Vasut
2022-10-09 22:58 ` Michał Mirosław
2022-10-10 0:00 ` Marek Vasut
2022-10-10 13:27 ` Hans de Goede
2022-10-10 16:45 ` Marek Vasut
2022-10-10 17:31 ` Hans de Goede
2022-10-10 17:39 ` Marek Vasut
2022-10-09 23:08 ` [PATCH 1/2] power: supply: bq25890: Add CC voltage to ADC properties Michał Mirosław
2022-10-10 13:50 ` Hans de Goede
2022-10-10 19:22 ` Marek Vasut [this message]
2022-10-11 7:38 ` Hans de Goede
2022-10-11 16:35 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c528ae92-26bd-e6a9-a406-93a077d2fab7@denx.de \
--to=marex@denx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-pm@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox