* [PATCH] cpufreq: arm_big_little: fix module license spec [not found] <mvmmwbqateb.fsf@hawking.suse.de> @ 2014-07-31 7:36 ` Uwe Kleine-König 2014-08-01 9:22 ` Viresh Kumar 2014-08-07 14:00 ` Andreas Schwab 0 siblings, 2 replies; 5+ messages in thread From: Uwe Kleine-König @ 2014-07-31 7:36 UTC (permalink / raw) To: Andreas Schwab, Viresh Kumar, Sudeep Holla Cc: kernel, linux-pm, linux-arm-kernel Having no license specification in a module taints the kernel during load with: arm_big_little: module license 'unspecified' taints kernel. and also the linker doesn't allow it to make use of GPL-exported symbols which in this case also results in errors like: arm_big_little: Unknown symbol cpufreq_register_driver (err 0) . The header of the driver specifies a GPL v2 license, so note that accordingly. While at it also add a description and an author and fix the license in a companion file to explicit v2. Reported-by: Andreas Schwab <schwab@suse.de> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/cpufreq/arm_big_little.c | 4 ++++ drivers/cpufreq/arm_big_little_dt.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c index 1f4d4e315057..b600f3107bef 100644 --- a/drivers/cpufreq/arm_big_little.c +++ b/drivers/cpufreq/arm_big_little.c @@ -593,3 +593,7 @@ void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) arm_bL_ops = NULL; } EXPORT_SYMBOL_GPL(bL_cpufreq_unregister); + +MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); +MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/cpufreq/arm_big_little_dt.c b/drivers/cpufreq/arm_big_little_dt.c index 8d9d59108906..4550f6976768 100644 --- a/drivers/cpufreq/arm_big_little_dt.c +++ b/drivers/cpufreq/arm_big_little_dt.c @@ -114,4 +114,4 @@ module_platform_driver(generic_bL_platdrv); MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver via DT"); -MODULE_LICENSE("GPL"); +MODULE_LICENSE("GPL v2"); -- 2.0.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] cpufreq: arm_big_little: fix module license spec 2014-07-31 7:36 ` [PATCH] cpufreq: arm_big_little: fix module license spec Uwe Kleine-König @ 2014-08-01 9:22 ` Viresh Kumar 2014-08-07 14:00 ` Andreas Schwab 1 sibling, 0 replies; 5+ messages in thread From: Viresh Kumar @ 2014-08-01 9:22 UTC (permalink / raw) To: Uwe Kleine-König Cc: Andreas Schwab, Sudeep Holla, Sascha Hauer, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 31 July 2014 13:06, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Having no license specification in a module taints the kernel during load > with: > > arm_big_little: module license 'unspecified' taints kernel. > > and also the linker doesn't allow it to make use of GPL-exported symbols > which in this case also results in errors like: > > arm_big_little: Unknown symbol cpufreq_register_driver (err 0) > > . The header of the driver specifies a GPL v2 license, so note that > accordingly. While at it also add a description and an author and fix > the license in a companion file to explicit v2. > > Reported-by: Andreas Schwab <schwab@suse.de> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/cpufreq/arm_big_little.c | 4 ++++ > drivers/cpufreq/arm_big_little_dt.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c > index 1f4d4e315057..b600f3107bef 100644 > --- a/drivers/cpufreq/arm_big_little.c > +++ b/drivers/cpufreq/arm_big_little.c > @@ -593,3 +593,7 @@ void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > arm_bL_ops = NULL; > } > EXPORT_SYMBOL_GPL(bL_cpufreq_unregister); > + > +MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); > +MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); > +MODULE_LICENSE("GPL v2"); > diff --git a/drivers/cpufreq/arm_big_little_dt.c b/drivers/cpufreq/arm_big_little_dt.c > index 8d9d59108906..4550f6976768 100644 > --- a/drivers/cpufreq/arm_big_little_dt.c > +++ b/drivers/cpufreq/arm_big_little_dt.c > @@ -114,4 +114,4 @@ module_platform_driver(generic_bL_platdrv); > > MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); > MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver via DT"); > -MODULE_LICENSE("GPL"); > +MODULE_LICENSE("GPL v2"); Thanks.. Acked-by: Viresh Kumar <viresh.kumar@linaro.org> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cpufreq: arm_big_little: fix module license spec 2014-07-31 7:36 ` [PATCH] cpufreq: arm_big_little: fix module license spec Uwe Kleine-König 2014-08-01 9:22 ` Viresh Kumar @ 2014-08-07 14:00 ` Andreas Schwab 2014-08-07 15:29 ` Uwe Kleine-König 1 sibling, 1 reply; 5+ messages in thread From: Andreas Schwab @ 2014-08-07 14:00 UTC (permalink / raw) To: Uwe Kleine-König Cc: Viresh Kumar, Sudeep Holla, kernel, linux-pm, linux-arm-kernel Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > Having no license specification in a module taints the kernel during load > with: > > arm_big_little: module license 'unspecified' taints kernel. > > and also the linker doesn't allow it to make use of GPL-exported symbols > which in this case also results in errors like: > > arm_big_little: Unknown symbol cpufreq_register_driver (err 0) > > . The header of the driver specifies a GPL v2 license, so note that > accordingly. While at it also add a description and an author and fix > the license in a companion file to explicit v2. > > Reported-by: Andreas Schwab <schwab@suse.de> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/cpufreq/arm_big_little.c | 4 ++++ > drivers/cpufreq/arm_big_little_dt.c | 2 +- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c > index 1f4d4e315057..b600f3107bef 100644 > --- a/drivers/cpufreq/arm_big_little.c > +++ b/drivers/cpufreq/arm_big_little.c > @@ -593,3 +593,7 @@ void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > arm_bL_ops = NULL; > } > EXPORT_SYMBOL_GPL(bL_cpufreq_unregister); > + > +MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); > +MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); > +MODULE_LICENSE("GPL v2"); drivers/cpufreq/arm_big_little.c:613:15: error: expected declaration specifiers or ‘...’ before string constant MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); ^ drivers/cpufreq/arm_big_little.c:614:20: error: expected declaration specifiers or ‘...’ before string constant MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); ^ drivers/cpufreq/arm_big_little.c:615:16: error: expected declaration specifiers or ‘...’ before string constant MODULE_LICENSE("GPL v2"); ^ Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cpufreq: arm_big_little: fix module license spec 2014-08-07 14:00 ` Andreas Schwab @ 2014-08-07 15:29 ` Uwe Kleine-König 2014-08-07 15:33 ` Andreas Schwab 0 siblings, 1 reply; 5+ messages in thread From: Uwe Kleine-König @ 2014-08-07 15:29 UTC (permalink / raw) To: Andreas Schwab Cc: Viresh Kumar, Sudeep Holla, kernel, linux-pm, linux-arm-kernel On Thu, Aug 07, 2014 at 04:00:20PM +0200, Andreas Schwab wrote: > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > > > Having no license specification in a module taints the kernel during load > > with: > > > > arm_big_little: module license 'unspecified' taints kernel. > > > > and also the linker doesn't allow it to make use of GPL-exported symbols > > which in this case also results in errors like: > > > > arm_big_little: Unknown symbol cpufreq_register_driver (err 0) > > > > . The header of the driver specifies a GPL v2 license, so note that > > accordingly. While at it also add a description and an author and fix > > the license in a companion file to explicit v2. > > > > Reported-by: Andreas Schwab <schwab@suse.de> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > drivers/cpufreq/arm_big_little.c | 4 ++++ > > drivers/cpufreq/arm_big_little_dt.c | 2 +- > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c > > index 1f4d4e315057..b600f3107bef 100644 > > --- a/drivers/cpufreq/arm_big_little.c > > +++ b/drivers/cpufreq/arm_big_little.c > > @@ -593,3 +593,7 @@ void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) > > arm_bL_ops = NULL; > > } > > EXPORT_SYMBOL_GPL(bL_cpufreq_unregister); > > + > > +MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); > > +MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); > > +MODULE_LICENSE("GPL v2"); > > drivers/cpufreq/arm_big_little.c:613:15: error: expected declaration specifiers or ‘...’ before string constant > MODULE_AUTHOR("Viresh Kumar <viresh.kumar@linaro.org>"); > ^ > drivers/cpufreq/arm_big_little.c:614:20: error: expected declaration specifiers or ‘...’ before string constant > MODULE_DESCRIPTION("Generic ARM big LITTLE cpufreq driver"); > ^ > drivers/cpufreq/arm_big_little.c:615:16: error: expected declaration specifiers or ‘...’ before string constant > MODULE_LICENSE("GPL v2"); > ^ > Does adding #include <linux/module.h> in that file fix the problem? Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cpufreq: arm_big_little: fix module license spec 2014-08-07 15:29 ` Uwe Kleine-König @ 2014-08-07 15:33 ` Andreas Schwab 0 siblings, 0 replies; 5+ messages in thread From: Andreas Schwab @ 2014-08-07 15:33 UTC (permalink / raw) To: Uwe Kleine-König Cc: Viresh Kumar, Sudeep Holla, kernel, linux-pm, linux-arm-kernel Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes: > Does adding > > #include <linux/module.h> > > in that file fix the problem? Yes, it does. Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-07 15:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <mvmmwbqateb.fsf@hawking.suse.de>
2014-07-31 7:36 ` [PATCH] cpufreq: arm_big_little: fix module license spec Uwe Kleine-König
2014-08-01 9:22 ` Viresh Kumar
2014-08-07 14:00 ` Andreas Schwab
2014-08-07 15:29 ` Uwe Kleine-König
2014-08-07 15:33 ` Andreas Schwab
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox