[vireshk:cpufreq/stats/cleanups 12/14] drivers/cpufreq/cpufreq_stats.c:19:1: sparse: symbol 'cpufreq_stats_lock' was not declared. Should it be static?

[vireshk:cpufreq/stats/cleanups 12/14] drivers/cpufreq/cpufreq_stats.c:19:1: sparse: symbol 'cpufreq_stats_lock' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.linaro.org/people/vireshk/linux cpufreq/stats/cleanups
head:   f6439741b76da59257758838e8b24472831e850c
commit: 2194c3c381af6cbfe8ab4fda481e07a004446e30 [12/14] cpufreq: stats: replace spinlock with mutex
reproduce:
  # apt-get install sparse
  git checkout 2194c3c381af6cbfe8ab4fda481e07a004446e30
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/cpufreq/cpufreq_stats.c:19:1: sparse: symbol 'cpufreq_stats_lock' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation

[PATCH vireshk] cpufreq: stats: cpufreq_stats_lock can be static

[kbuild test robot]

drivers/cpufreq/cpufreq_stats.c:19:1: sparse: symbol 'cpufreq_stats_lock' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 cpufreq_stats.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
index d333659..de55ca8 100644
--- a/drivers/cpufreq/cpufreq_stats.c
+++ b/drivers/cpufreq/cpufreq_stats.c
@@ -16,7 +16,7 @@
 #include <linux/slab.h>
 #include <linux/cputime.h>
 
-DEFINE_MUTEX(cpufreq_stats_lock);
+static DEFINE_MUTEX(cpufreq_stats_lock);
 
 struct cpufreq_stats {
 	unsigned int total_trans;

Re: [vireshk:cpufreq/stats/cleanups 12/14] drivers/cpufreq/cpufreq_stats.c:19:1: sparse: symbol 'cpufreq_stats_lock' was not declared. Should it be static?

[Viresh Kumar]

On 19 December 2014 at 13:47, kbuild test robot <fengguang.wu@intel.com> wrote:
> tree:   https://git.linaro.org/people/vireshk/linux cpufreq/stats/cleanups
> head:   f6439741b76da59257758838e8b24472831e850c
> commit: 2194c3c381af6cbfe8ab4fda481e07a004446e30 [12/14] cpufreq: stats: replace spinlock with mutex
> reproduce:
>   # apt-get install sparse
>   git checkout 2194c3c381af6cbfe8ab4fda481e07a004446e30
>   make ARCH=x86_64 allmodconfig
>   make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/cpufreq/cpufreq_stats.c:19:1: sparse: symbol 'cpufreq_stats_lock' was not declared. Should it be static?
>
> Please review and possibly fold the followup patch.

Thanks fixed.