* [PATCH] power/smb347-charger.c: set IRQF_ONESHOT flag to ensure IRQ request
@ 2015-03-02 14:32 Valentin Rothberg
2015-03-07 18:42 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Valentin Rothberg @ 2015-03-02 14:32 UTC (permalink / raw)
To: sre, dbaryshkov, dwmw2, linux-pm, linux-kernel; +Cc: Valentin Rothberg
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request may fail.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
---
drivers/power/smb347-charger.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/smb347-charger.c b/drivers/power/smb347-charger.c
index acf84e8..e9702de 100644
--- a/drivers/power/smb347-charger.c
+++ b/drivers/power/smb347-charger.c
@@ -842,7 +842,8 @@ static int smb347_irq_init(struct smb347_charger *smb,
goto fail;
ret = request_threaded_irq(irq, NULL, smb347_interrupt,
- IRQF_TRIGGER_FALLING, client->name, smb);
+ IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+ client->name, smb);
if (ret < 0)
goto fail_gpio;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power/smb347-charger.c: set IRQF_ONESHOT flag to ensure IRQ request
2015-03-02 14:32 [PATCH] power/smb347-charger.c: set IRQF_ONESHOT flag to ensure IRQ request Valentin Rothberg
@ 2015-03-07 18:42 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2015-03-07 18:42 UTC (permalink / raw)
To: Valentin Rothberg; +Cc: dbaryshkov, dwmw2, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
Hi,
On Mon, Mar 02, 2015 at 03:32:48PM +0100, Valentin Rothberg wrote:
> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
> bogus threaded irq requests") threaded IRQs without a primary handler
> need to be requested with IRQF_ONESHOT, otherwise the request may fail.
>
> Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
>
> Signed-off-by: Valentin Rothberg <Valentin.Rothberg@lip6.fr>
Thanks, applied:
http://git.infradead.org/battery-2.6.git/commit/1d93b850296339082b7ace26ed20385d3bc5e2c6
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-07 18:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-02 14:32 [PATCH] power/smb347-charger.c: set IRQF_ONESHOT flag to ensure IRQ request Valentin Rothberg
2015-03-07 18:42 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox