From: Chris Redpath <chris.redpath@arm.com>
To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc: morten.rasmussen@arm.com, dietmar.eggemann@arm.com,
Chris Redpath <chris.redpath@arm.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
"4 . 9+" <stable@vger.kernel.org>
Subject: [PATCH] cpufreq: schedutil: Examine the correct CPU when we update util
Date: Thu, 2 Nov 2017 10:54:38 +0000 [thread overview]
Message-ID: <20171102105438.14258-1-chris.redpath@arm.com> (raw)
Since:
4296f23ed cpufreq: schedutil: Fix per-CPU structure initialization in
sugov_start()
We lost the value of sg_cpu->cpu which is assigned during
sugov_register. The memset in sugov_start overwrites it with zero.
This leads to always looking at the utilization of CPU0 instead of
the one we just updated when we do a utilization update callback.
Let's fix this by consolidating the initialization code into
sugov_start().
Fixes: 4296f23ed49a ("cpufreq: schedutil: Fix per-CPU structure initialization in sugov_start()")
Signed-off-by: Chris Redpath <chris.redpath@arm.com>
Reviewed-by: Patrick Bellasi <patrick.bellasi@arm.com>
Reviewed-by: Brendan Jackman <brendan.jackman@arm.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: 4.9+ <stable@vger.kernel.org>
---
kernel/sched/cpufreq_schedutil.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 6c1a7fcfa2a7..eeb7e0a1d861 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -731,6 +731,7 @@ static int sugov_start(struct cpufreq_policy *policy)
sg_cpu->sg_policy = sg_policy;
sg_cpu->flags = SCHED_CPUFREQ_RT;
sg_cpu->iowait_boost_max = policy->cpuinfo.max_freq;
+ sg_cpu->cpu = cpu;
}
for_each_cpu(cpu, policy->cpus) {
@@ -793,11 +794,6 @@ struct cpufreq_governor *cpufreq_default_governor(void)
static int __init sugov_register(void)
{
- int cpu;
-
- for_each_possible_cpu(cpu)
- per_cpu(sugov_cpu, cpu).cpu = cpu;
-
return cpufreq_register_governor(&schedutil_gov);
}
fs_initcall(sugov_register);
--
2.13.1.449.g02a2850
next reply other threads:[~2017-11-02 10:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 10:54 Chris Redpath [this message]
2017-11-02 11:10 ` [PATCH] cpufreq: schedutil: Examine the correct CPU when we update util Viresh Kumar
2017-11-02 11:38 ` [PATCH v2] " Chris Redpath
2017-11-02 11:40 ` Viresh Kumar
2017-11-02 12:06 ` Chris Redpath
2017-11-03 3:40 ` Viresh Kumar
2017-11-03 13:36 ` [PATCH v3] " Chris Redpath
2017-11-03 15:45 ` Viresh Kumar
2017-11-07 9:49 ` Chris Redpath
2017-11-07 9:59 ` Viresh Kumar
2017-11-07 10:09 ` Rafael J. Wysocki
2017-11-07 11:03 ` Chris Redpath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102105438.14258-1-chris.redpath@arm.com \
--to=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=stable@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox