From: Viresh Kumar <viresh.kumar@linaro.org>
To: Chris Redpath <chris.redpath@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Morten Rasmussen <morten.rasmussen@arm.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH v2] cpufreq: schedutil: Examine the correct CPU when we update util
Date: Fri, 3 Nov 2017 09:10:22 +0530 [thread overview]
Message-ID: <20171103034022.GD4240@vireshk-i7> (raw)
In-Reply-To: <037169f3-61f9-b29e-9561-0f7dba213cd5@arm.com>
On 02-11-17, 12:06, Chris Redpath wrote:
> According to my diff, this was the commit which switched from assigning
> the values directly (and not overwriting the cpu member, which was
> introduced in the other commit you reference) to using a memset and
> clearing the whole struct.
I understand what you want to convey here but the log says something
else according to me. It says:
"Since: 4296f23ed cpufreq: schedutil: Fix per-CPU structure
initialization in sugov_start(), We lost the value of sg_cpu->cpu
which is assigned during sugov_register."
Reading this line it looks like sg_cpu->cpu was screwed up by
4296f23ed, which happened in 4.9. But the sg_cpu->cpu field itself got
added in 4.14 and so I think we should write it differently.
If I were you, I wouldn't mention 4296f23ed here at all but just say
that memset() is clearing the value of sg_cpu->cpu, fix that.
Thanks.
--
viresh
next prev parent reply other threads:[~2017-11-03 3:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 10:54 [PATCH] cpufreq: schedutil: Examine the correct CPU when we update util Chris Redpath
2017-11-02 11:10 ` Viresh Kumar
2017-11-02 11:38 ` [PATCH v2] " Chris Redpath
2017-11-02 11:40 ` Viresh Kumar
2017-11-02 12:06 ` Chris Redpath
2017-11-03 3:40 ` Viresh Kumar [this message]
2017-11-03 13:36 ` [PATCH v3] " Chris Redpath
2017-11-03 15:45 ` Viresh Kumar
2017-11-07 9:49 ` Chris Redpath
2017-11-07 9:59 ` Viresh Kumar
2017-11-07 10:09 ` Rafael J. Wysocki
2017-11-07 11:03 ` Chris Redpath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103034022.GD4240@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=chris.redpath@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox