From: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, bleung@chromium.org, sre@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
dlaurie@chromium.org, lamzin@google.com, bartfab@google.com,
derat@google.com, dtor@google.com, sjg@chromium.org,
jchwong@chromium.org, Nick Crews <ncrews@chromium.org>
Subject: Re: [PATCH v5] power_supply: platform/chrome: wilco_ec: Add charging config driver
Date: Sat, 20 Apr 2019 17:37:54 +0800 [thread overview]
Message-ID: <201904201756.6pNuTXy5%lkp@intel.com> (raw)
In-Reply-To: <20190418233838.149545-1-ncrews@chromium.org>
Hi Nick,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.1-rc5 next-20190418]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Nick-Crews/power_supply-platform-chrome-wilco_ec-Add-charging-config-driver/20190420-041913
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/power/supply/wilco-charger.c:46:14: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_STANDARD'
drivers/power/supply/wilco-charger.c:48:14: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE'
drivers/power/supply/wilco-charger.c:50:14: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_CUSTOM'
>> drivers/power/supply/wilco-charger.c:46:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:48:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:50:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:66:24: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_STANDARD'
drivers/power/supply/wilco-charger.c:68:24: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE'
drivers/power/supply/wilco-charger.c:70:24: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_CUSTOM'
drivers/power/supply/wilco-charger.c:78:9: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD'
drivers/power/supply/wilco-charger.c:79:9: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD'
drivers/power/supply/wilco-charger.c:95:14: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD'
drivers/power/supply/wilco-charger.c:98:14: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD'
drivers/power/supply/wilco-charger.c:95:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:98:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:132:14: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD'
drivers/power/supply/wilco-charger.c:138:14: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD'
drivers/power/supply/wilco-charger.c:132:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:138:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:46:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:48:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:50:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:95:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:98:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:132:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:138:14: sparse: Expected constant expression in case statement
vim +/case +46 drivers/power/supply/wilco-charger.c
37
38 /* Convert from POWER_SUPPLY_PROP_CHARGE_TYPE value to the EC's charge mode */
39 static enum charge_mode psp_val_to_charge_mode(int psp_val)
40 {
41 switch (psp_val) {
42 case POWER_SUPPLY_CHARGE_TYPE_TRICKLE:
43 return CHARGE_MODE_AC;
44 case POWER_SUPPLY_CHARGE_TYPE_FAST:
45 return CHARGE_MODE_EXP;
> 46 case POWER_SUPPLY_CHARGE_TYPE_STANDARD:
47 return CHARGE_MODE_STD;
48 case POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE:
49 return CHARGE_MODE_AUTO;
50 case POWER_SUPPLY_CHARGE_TYPE_CUSTOM:
51 return CHARGE_MODE_CUSTOM;
52 default:
53 return CHARGE_MODE_ILLEGAL;
54 }
55 }
56
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com>
To: Nick Crews <ncrews@chromium.org>
Cc: kbuild-all@01.org, bleung@chromium.org, sre@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
dlaurie@chromium.org, lamzin@google.com, bartfab@google.com,
derat@google.com, dtor@google.com, sjg@chromium.org,
jchwong@chromium.org, Nick Crews <ncrews@chromium.org>
Subject: Re: [PATCH v5] power_supply: platform/chrome: wilco_ec: Add charging config driver
Date: Sat, 20 Apr 2019 17:37:54 +0800 [thread overview]
Message-ID: <201904201756.6pNuTXy5%lkp@intel.com> (raw)
Message-ID: <20190420093754.99cJ7gEXfN8KETtf15c1kIG6Gp8UtTkLe8xz7ETyQRY@z> (raw)
In-Reply-To: <20190418233838.149545-1-ncrews@chromium.org>
Hi Nick,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.1-rc5 next-20190418]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Nick-Crews/power_supply-platform-chrome-wilco_ec-Add-charging-config-driver/20190420-041913
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/power/supply/wilco-charger.c:46:14: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_STANDARD'
drivers/power/supply/wilco-charger.c:48:14: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE'
drivers/power/supply/wilco-charger.c:50:14: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_CUSTOM'
>> drivers/power/supply/wilco-charger.c:46:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:48:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:50:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:66:24: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_STANDARD'
drivers/power/supply/wilco-charger.c:68:24: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE'
drivers/power/supply/wilco-charger.c:70:24: sparse: undefined identifier 'POWER_SUPPLY_CHARGE_TYPE_CUSTOM'
drivers/power/supply/wilco-charger.c:78:9: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD'
drivers/power/supply/wilco-charger.c:79:9: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD'
drivers/power/supply/wilco-charger.c:95:14: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD'
drivers/power/supply/wilco-charger.c:98:14: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD'
drivers/power/supply/wilco-charger.c:95:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:98:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:132:14: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD'
drivers/power/supply/wilco-charger.c:138:14: sparse: undefined identifier 'POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD'
drivers/power/supply/wilco-charger.c:132:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:138:14: sparse: incompatible types for 'case' statement
drivers/power/supply/wilco-charger.c:46:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:48:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:50:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:95:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:98:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:132:14: sparse: Expected constant expression in case statement
drivers/power/supply/wilco-charger.c:138:14: sparse: Expected constant expression in case statement
vim +/case +46 drivers/power/supply/wilco-charger.c
37
38 /* Convert from POWER_SUPPLY_PROP_CHARGE_TYPE value to the EC's charge mode */
39 static enum charge_mode psp_val_to_charge_mode(int psp_val)
40 {
41 switch (psp_val) {
42 case POWER_SUPPLY_CHARGE_TYPE_TRICKLE:
43 return CHARGE_MODE_AC;
44 case POWER_SUPPLY_CHARGE_TYPE_FAST:
45 return CHARGE_MODE_EXP;
> 46 case POWER_SUPPLY_CHARGE_TYPE_STANDARD:
47 return CHARGE_MODE_STD;
48 case POWER_SUPPLY_CHARGE_TYPE_ADAPTIVE:
49 return CHARGE_MODE_AUTO;
50 case POWER_SUPPLY_CHARGE_TYPE_CUSTOM:
51 return CHARGE_MODE_CUSTOM;
52 default:
53 return CHARGE_MODE_ILLEGAL;
54 }
55 }
56
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
next prev parent reply other threads:[~2019-04-20 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <--to=enric.balletbo@collabora.com>
2019-04-18 23:38 ` [PATCH v5] power_supply: platform/chrome: wilco_ec: Add charging config driver Nick Crews
2019-04-18 23:38 ` Nick Crews
2019-04-20 4:30 ` [PATCH] power_supply: platform/chrome: wilco_ec: fix ptr_ret.cocci warnings kbuild test robot
2019-04-20 4:30 ` kbuild test robot
2019-04-20 9:37 ` kbuild test robot [this message]
2019-04-20 9:37 ` [PATCH v5] power_supply: platform/chrome: wilco_ec: Add charging config driver kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201904201756.6pNuTXy5%lkp@intel.com \
--to=lkp@intel.com \
--cc=bartfab@google.com \
--cc=bleung@chromium.org \
--cc=derat@google.com \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=jchwong@chromium.org \
--cc=kbuild-all@01.org \
--cc=lamzin@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ncrews@chromium.org \
--cc=sjg@chromium.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox